Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the changes from severity to score. #2854

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

y0urself
Copy link
Member

What:

  • Revert the change from severity -> score
  • It is a float value again

Why:

  • Changes in Backend

How:

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #2854 (13ab2ee) into gsa-21.04 (74a1fd3) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-21.04    #2854      +/-   ##
=============================================
- Coverage      53.83%   53.82%   -0.01%     
=============================================
  Files           1075     1075              
  Lines          26226    26231       +5     
  Branches        7491     7498       +7     
=============================================
+ Hits           14118    14120       +2     
- Misses         10993    10996       +3     
  Partials        1115     1115              
Impacted Files Coverage Δ
gsa/src/web/pages/nvts/solution.js 22.22% <0.00%> (-11.12%) ⬇️
gsa/src/gmp/models/certbund.js 100.00% <100.00%> (ø)
gsa/src/gmp/models/cpe.js 94.73% <100.00%> (-0.27%) ⬇️
gsa/src/gmp/models/cve.js 98.21% <100.00%> (-0.04%) ⬇️
gsa/src/gmp/models/dfncert.js 100.00% <100.00%> (ø)
gsa/src/gmp/models/nvt.js 99.00% <100.00%> (+0.07%) ⬆️
gsa/src/gmp/models/ovaldef.js 94.54% <100.00%> (-0.10%) ⬇️
gsa/src/web/pages/tasks/actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27da6f...13ab2ee. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review April 14, 2021 11:19
@y0urself y0urself requested a review from a team April 14, 2021 11:19
@saberlynx saberlynx merged commit c3064e6 into greenbone:gsa-21.04 Apr 14, 2021
@sarahd93 sarahd93 added the port-to-main Use mergifiy to port PR to master label Apr 14, 2021
bjoernricks added a commit that referenced this pull request Apr 20, 2021
Revert the changes from severity to score. (backport #2854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-main Use mergifiy to port PR to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants