Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better defaults for installation locations #3045

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jun 30, 2021

What:

These defaults assume the installation will be system wide either on
/usr or /usr/local prefix. If the user wants to separate the
installation completely from their system SYSCONFDIR, LOCALSTATEDIR,
GSAD_PID_DIR, GVM_RUN_DIR and SYSTEMD_SERVICE_DIR need to be adjusted.

Why:

How:

Checklist:

  • Tests
  • CHANGELOG Entry
  • Labels for ports to other branches

@bjoernricks bjoernricks requested a review from a team as a code owner June 30, 2021 14:07
@bjoernricks bjoernricks marked this pull request as draft June 30, 2021 14:07
These defaults assume the installation will be system wide either on
/usr or /usr/local prefix. If the user wants to separate the
installation completely from their system SYSCONFDIR, LOCALSTATEDIR,
GSAD_PID_DIR, GVM_RUN_DIR and SYSTEMD_SERVICE_DIR need to be adjusted.
@bjoernricks bjoernricks force-pushed the use-better-defaults branch from 0e0ae14 to b36dc4b Compare June 30, 2021 14:14
We just give an example on how to run gsad. Distributions should patch
the file accordingly.
We install the file as gsad. Debian packagers are using
greenbone-security-assistant.service.
The file is not used by Debian therefore we shouldn't use it too.
@bjoernricks bjoernricks marked this pull request as ready for review June 30, 2021 14:39
@bjoernricks bjoernricks added port-to-oldstable Use mergify to port PR to oldstable port-to-21.10 labels Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port-to-oldstable Use mergify to port PR to oldstable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants