From 9eee66a53f8890d6ac4c72afc5d92576fac79c65 Mon Sep 17 00:00:00 2001 From: Matt Mundell Date: Wed, 11 Sep 2019 14:40:19 +0200 Subject: [PATCH 1/4] Remove the special default for details from GET_REPORTS --- src/gmp.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/gmp.c b/src/gmp.c index 4f5f61b11..0c316cd95 100644 --- a/src/gmp.c +++ b/src/gmp.c @@ -6273,16 +6273,6 @@ gmp_xml_handle_start_element (/* unused */ GMarkupParseContext* context, attribute_names, attribute_values); - /* Special case details with default 1, for backward - * compatibility. */ - if (find_attribute (attribute_names, attribute_values, - "details", &attribute)) - get_reports_data->report_get.details = strcmp (attribute, "0"); - else - get_reports_data->report_get.details = 1; - get_reports_data->get.details - = get_reports_data->report_get.details; - g_free (get_reports_data->report_get.filt_id); get_reports_data->report_get.filt_id = NULL; append_attribute (attribute_names, attribute_values, From 8f8626a19c4203b0d4831942c984b040300ade64 Mon Sep 17 00:00:00 2001 From: Matt Mundell Date: Wed, 11 Sep 2019 14:44:16 +0200 Subject: [PATCH 2/4] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c63d05b98..2edd36407 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Send delete command to ospd after stopping the task. [#710](https://github.com/greenbone/gvmd/pull/710) - Check whether hosts are alive and have results when adding them in slave scans. [#717](https://github.com/greenbone/gvmd/pull/717) [#736](https://github.com/greenbone/gvmd/pull/736) - New columns Ports, Apps, Distance, and Auth in the CSV Hosts report format [#733](https://github.com/greenbone/gvmd/pull/733) +- The details attribute of GET_REPORTS now defaults to 0 [#747](https://github.com/greenbone/gvmd/pull/747) ### Fixed - A PostgreSQL statement order issue [#611](https://github.com/greenbone/gvmd/issues/611) has been addressed [#642](https://github.com/greenbone/gvmd/pull/642) From 033819ccb0da04d45f07ef9e3f5aa8ae2c683498 Mon Sep 17 00:00:00 2001 From: Matt Mundell Date: Wed, 11 Sep 2019 14:50:15 +0200 Subject: [PATCH 3/4] Add CHANGE doc for default change --- src/schema_formats/XML/GMP.xml.in | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/schema_formats/XML/GMP.xml.in b/src/schema_formats/XML/GMP.xml.in index c13f26c48..eabbde736 100644 --- a/src/schema_formats/XML/GMP.xml.in +++ b/src/schema_formats/XML/GMP.xml.in @@ -27176,6 +27176,16 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + GET_REPORTS + Default of "details" attribute is now 0 + +

+ The default of the "details" attribute has changed from 1 to 0. + This matches the defaults of all the other GET commands. +

+ + 9.0 + GET_REPORTS Remove report type "assets" From 18f6ba0ea9b9f77e2a82d003a0a9f0ae630d987d Mon Sep 17 00:00:00 2001 From: Matt Mundell Date: Fri, 13 Sep 2019 14:48:59 +0200 Subject: [PATCH 4/4] Fix CHANGE doc --- src/schema_formats/XML/GMP.xml.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/schema_formats/XML/GMP.xml.in b/src/schema_formats/XML/GMP.xml.in index eabbde736..efbe79273 100644 --- a/src/schema_formats/XML/GMP.xml.in +++ b/src/schema_formats/XML/GMP.xml.in @@ -27186,6 +27186,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 9.0 + GET_REPORTS Remove report type "assets"