Font calibration #347
Merged
Font calibration #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to have been some changes to the way heights are calculated that I can't track down. Even going back to known good installations still gives this changes, so I suspect it's something in the way LuaTeX or some package we depend on operates.
Because the default value for this distance was not exactly what the calculations would have predicted, tests with extreme low notes have some minor changes (though you'd have been hard pressed to notice them by eye).
These are the tests which have changed expectations as a result of the elimination of `noteadditionalspacelinestext`. These should be the old expectations (if I've done my checkouts from history correctly), and pass as backwards compatibility tests (where `allowdeprecated` is set to true, so the old behavior should show up).
Not all tests are converted. I deleted some to reduce the number of new tests (and because I didn't feel like creating a whole bunch of new preamble files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to gregorio-project/gregorio#1526