Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nabc vertical position should not depend on the pitch of the gabc notes #1153

Closed
jakubjelinek opened this issue Jun 21, 2016 · 1 comment
Closed

Nabc vertical position should not depend on the pitch of the gabc notes #1153

jakubjelinek opened this issue Jun 21, 2016 · 1 comment

Comments

@jakubjelinek
Copy link
Contributor

As has been reported on gregorio-users, when a score line contains l or higher notes, the baseline seems to be moved above (verified already in 4.1), which is not bad for , but undesirable for nabc, which has a way of positioning the neumes vertically.
Wonder if it is \gre@dimen@additionaltopspacealt and \gre@space@count@additionaltopspacealtthreshold that matters in this case. If yes, wonder if we could not then duplicate/modify the \GreSetTextAboveLines and \def\gre@typesettextabovelines macros as well as add additionaltopspacenabc* variants of the above (use Nabc or nabc instead of Text and text), so that it could be configurable differently for nabc. And by default use higher treshold.
Could this still be done for 4.2?
jakubjelinek added a commit to jakubjelinek/gregorio that referenced this issue Jun 21, 2016
@jakubjelinek
Copy'n'paste approach for issue gregorio-project#1153.
69faf7d
henryso added a commit that referenced this issue Jun 23, 2016
@henryso
Merge pull request #1154 from jakubjelinek/release-4.2
c1b861e 
Copy'n'paste approach for issue #1153.
henryso added a commit to henryso/gregorio-test that referenced this issue Jun 23, 2016
@henryso
Accepted updated results after merging gregorio-project/gregorio#1154.
e5a206c 
Tests gregorio-project/gregorio#1153.
@henryso henryso mentioned this issue Jun 23, 2016
Merged
@henryso
Copy link
Contributor

henryso commented Jun 23, 2016

Copied from gregorio-project/gregorio-test#242, the following changes to the documentation are necessary:

  • additionaltopspacenabcthreshold should be added as a new count to Command_Index_User.tex
  • \gre@typesettextabovelines should be updated (to document the #2 argument) in Command_Index_internal.tex
  • \GreSetNabcAboveLines should be added to Command_Index_gregorio.tex

@henryso henryso closed this as completed Jun 24, 2016
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Sep 24, 2016
@rpspringuel
Merge branch 'release-4.2'
3ccb375 
* release-4.2: (72 commits)
  Added a test for the suppression of \GreLastOfScore. Tests gregorio-project/gregorio#1205.
  Updated test harness to handle gregorio executable with version number. Tests gregorio-project/gregorio#1197.
  Updated tests to match the oriscus orientation at unison change. Tests gregorio-project/gregorio#1177.
  Small inconsistency
  Added a test to exercise per-line dimension changes. Tests gregorio-project/gregorio#1156.
  Accepted test results after merge.
  accept tests for fix-1144
  accept changes for #1169
  accept tests for 1146
  accept tests for #1146
  accept changes for fix-1138
  changes for fix-1137
  Accepted updated results after merging gregorio-project/gregorio#1154. Tests gregorio-project/gregorio#1153.
  Accepted updated results after merge of release-4.2 into fix-1155.
  accept changes for fix-1152
  add tests for 1155
  accept tests for fix-1155
  Accepted expectations after #1148. Tests gregorio-project/gregorio#1145.
  Added the test from gregorio-project/gregorio#1141.
  Added the test from gregorio-project/gregorio#1139.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryso @jakubjelinek