-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctan #1210
Ctan #1210
Conversation
LuaTeX-ja prepends custom whatsit nodes to store e.g. text direction, breaking hard-coded paths like startnode.head.next.head.next.head in the center_translation() function. This patch uses node.travese_id() to find our desired nodes instead. Fixes gregorio-project#1180
It would appear that skips which are rescaled in Lua no longer have that change implicitly communicated back to TeX so I've added an explicit call. This fixes the issues with custom spacings not working in TeXLive 2016.
Like color and graphicx, the PlainTeX version of xstring is .tex not .sty
It's hard to review this because most of the file changes are copyright dates and version bumping, but these have all been reviewed elsewhere, so as long as the tests look OK, I think this is good. |
ok for me too |
Since I don't have the time to take care of this today (Sunday), on Monday I'll merge this and publish the release. I'll also prepare a new release candidate for 4.2 at the same time so that we can get people to test the installer changes there. |
Hi @rpspringuel, thank you so much for merging #1201. But, if it is at all possible, please "stop the press!" and wait just a little bit longer (say an hour or two?) before you actually release 4.1.5: I found a bug in my code, in that when
For example, "Adobe Ming Std" and "AR PL UKai TW" work fine, but STZhongSong, Fandol, cwTeXKai etc. would crash... for some reasons, with some fonts, the glyph node isn't found within the hbox, but instead one level deeper. I have a 3-line patch, not perfect, but at least no more crashing. I will write more at #1180 or #1201. Thanks again! |
PR showing what #1209 would do.