Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressed \GreLastOfScore if only no-element syllables follow it. #1211

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

henryso
Copy link
Contributor

@henryso henryso commented Aug 19, 2016

Fixes #1205.

I'm still unsure if this causes a problem related to #1116. @rpspringuel Would you be able to check?

No tests break, and I added the test from the issue.

Other than that, please review and merge if satisfactory.

@eroux
Copy link
Contributor

eroux commented Aug 19, 2016

Looks good to me, thanks a lot!

@rpspringuel
Copy link
Contributor

I'm not sure what you're concerned about, but will take a look at the results later. @henryso, if you could elaborate on what you're worried about, I'll have a better idea of what to look for.

@henryso
Copy link
Contributor Author

henryso commented Aug 19, 2016

In rpspringuel#5, I moved \GreLastOfScore to its position prior to this pull request. That was either part of the fix for #1110 itself or the issue you identified in #1116.

@rpspringuel
Copy link
Contributor

Well, the problem I identified in #1116 has to do with discretionaries mid-score, so this won't effect that (as evidenced by the fact that the clef-change test doesn't change). As for #1110, there is a test for that now and it looks good too, so I don't see any problems. All tests pass and the new test result looks good.

@henryso
Copy link
Contributor Author

henryso commented Aug 20, 2016

Ok, then I guess this is good to merge. Thanks!

@henryso henryso merged commit ba1fb79 into gregorio-project:release-4.2 Aug 20, 2016
@henryso henryso deleted the fix-1205 branch August 20, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants