A bit more cleanup

Author: grendello

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/IStructureInfo.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Reflection;
 
 namespace Xamarin.Android.Tasks.LLVMIR;
 

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrBufferManager.cs

@@ -256,11 +256,11 @@ public bool LittleEndian {
 	public uint? StackAlignment                                               { get; set; }
 
 	public LlvmIrDataLayoutAggregateObjectAlignment? AggregateObjectAlignment { get; set; }
-	public List<LlvmIrDataLayoutFloatAlignment>? FloatAlignment                     { get; set; }
+	public List<LlvmIrDataLayoutFloatAlignment>? FloatAlignment               { get; set; }
 	public LlvmIrDataLayoutFunctionPointerAlignment? FunctionPointerAlignment { get; set; }
-	public List<LlvmIrDataLayoutIntegerAlignment>? IntegerAlignment                 { get; set; }
-	public List<LlvmIrDataLayoutVectorAlignment>? VectorAlignment                   { get; set; }
-	public List<LlvmIrDataLayoutPointerSize>? PointerSize                           { get; set; }
+	public List<LlvmIrDataLayoutIntegerAlignment>? IntegerAlignment           { get; set; }
+	public List<LlvmIrDataLayoutVectorAlignment>? VectorAlignment             { get; set; }
+	public List<LlvmIrDataLayoutPointerSize>? PointerSize                     { get; set; }
 
 	public List<uint>? NativeIntegerWidths                                    { get; set; }
 	public List<uint>? NonIntegralPointerTypeAddressSpaces                    { get; set; }

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrDataLayout.cs

@@ -1,8 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Globalization;
-using System.Linq;
-using System.Text;
 
 namespace Xamarin.Android.Tasks.LLVMIR
 {

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrFunction.cs

@@ -69,17 +69,6 @@ public void Add (AndroidTargetArch targetArch, LlvmIrFunctionAttribute attr)
 		list.Add (attr);
 	}
 
-	public void Add (LlvmIrFunctionAttributeSet sourceSet)
-	{
-		if (sourceSet == null) {
-			throw new ArgumentNullException (nameof (sourceSet));
-		}
-
-		foreach (LlvmIrFunctionAttribute attr in sourceSet) {
-			Add (attr);
-		}
-	}
-
 	public string Render ()
 	{
 		List<LlvmIrFunctionAttribute> list = attributes.ToList ();

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrFunctionAttributeSet.cs

@@ -148,23 +148,6 @@ public LlvmIrFunctionImplicitStartLabel (ulong num)
 		}
 	}
 
-	sealed class LlvmIrFunctionParameterItem : LlvmIrFunctionLocalItem
-	{
-		public LlvmIrFunctionParameter Parameter { get; }
-
-		public LlvmIrFunctionParameterItem (LlvmIrFunction.FunctionState state, LlvmIrFunctionParameter parameter)
-			: base (state, parameter.Name)
-		{
-			Parameter = parameter;
-			SkipInOutput = true;
-		}
-
-		protected override void DoWrite (GeneratorWriteContext context, LlvmIrGenerator generator)
-		{
-			throw new NotSupportedException ("Internal error: writing not supported for this item");
-		}
-	}
-
 	List<LlvmIrFunctionBodyItem> items;
 	HashSet<string> definedLabels;
 	LlvmIrFunction ownerFunction;

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrFunctionBody.cs

@@ -6,7 +6,6 @@ namespace Xamarin.Android.Tasks.LLVMIR;
 
 abstract class LlvmIrInstruction : LlvmIrFunctionBodyItem
 {
-	// TODO: add support for metadata
 	public string Mnemonic                          { get; }
 	public LlvmIrFunctionAttributeSet? AttributeSet { get; set; }
 

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrInstructions.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 
 using Xamarin.Android.Tools;
 
@@ -421,16 +420,6 @@ bool IsStructureArrayVariable (LlvmIrGlobalVariable variable)
 			return typeof(StructureInstance).IsAssignableFrom (elementType);
 		}
 
-		bool IsPointerArrayVariable (LlvmIrGlobalVariable variable)
-		{
-			if (!variable.Type.IsArray ()) {
-				return false;
-			}
-
-			Type elementType = variable.Type.GetArrayElementType ();
-			return elementType == typeof(IntPtr) || elementType == typeof(UIntPtr);
-		}
-
 		bool IsStructureVariable (LlvmIrGlobalVariable variable)
 		{
 			if (!typeof(StructureInstance).IsAssignableFrom (variable.Type)) {

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrModule.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 
 using Xamarin.Android.Tools;

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/LlvmIrModuleAArch64.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 
 using Xamarin.Android.Tools;