Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Story globals improvements #8

Closed
wants to merge 5 commits into from

Commits on Oct 22, 2024

  1. Futher updates to storybookjs#28716

    - Improve feature flag callouts
    - Add API details to migration notes and clarify examples
    - Restructure guides to use sub-heading structure instead of snippet tabs
        - Offers ability to explain differences between APIs more thoroughly
        - Also a better experience, because users' tab preference will not apply across snippets
    - Clarify example snippets
        - Only demonstate one concept per snippet
    - Adjust heading levels
    - Add globals API reference section
    - Improve snippet filenames
        - Remove redundant `storybook-` prefix
    - Prose tweaks
    kylegach authored and rajitkhanna committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8ac245b View commit details
    Browse the repository at this point in the history
  2. Remove TK

    kylegach authored and rajitkhanna committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    75add27 View commit details
    Browse the repository at this point in the history
  3. Address feedback

    - Explain globals API and feature flag once, at the top
    - Reference that callout in consistent manner throughout page
    - Wrap entire docs section in "feature flag callout" to better differentiate
    - Remove headings for with/without feature flag sections
        - Headings will be removed in SB 9+, so they're not a stable reference
    kylegach authored and rajitkhanna committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ba24b9f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Further updates

    - Polish and details
    - Make Viewport match structure and style of Backgrounds
    kylegach authored and rajitkhanna committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    63c1ce2 View commit details
    Browse the repository at this point in the history
  2. Typo

    Co-authored-by: jonniebigodes <joaocontadesenvolvimento@gmail.com>
    2 people authored and rajitkhanna committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fe71ac0 View commit details
    Browse the repository at this point in the history