Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
8506300
added logs and /robotic_platform prefix for topics
szknowak Oct 14, 2025
eef7bd8
initial
szknowak Oct 21, 2025
87c3588
parameters descriptions
szknowak Oct 21, 2025
6894a66
revert to main status
szknowak Oct 21, 2025
17f76a4
parameter print
szknowak Oct 22, 2025
8962bda
Board pose estimation
szknowak Oct 23, 2025
edab9d7
remove usused parameters
szknowak Oct 23, 2025
d66705e
Created script to generate aruco grids, working grid based calibration
szknowak Oct 23, 2025
53544a1
revert not needed changes
szknowak Oct 23, 2025
ac44925
revert not needed changes
szknowak Oct 23, 2025
65a7e85
added generating boards in .svg format, generated a few example aruco…
szknowak Oct 27, 2025
9597267
Charuco board generation:
szknowak Oct 28, 2025
d456e41
Refactor camera classes for handling 3 methods of calibration in a mo…
Oct 31, 2025
7c839a0
revert changes from previous logic which inquired idea od preforming …
Nov 3, 2025
b231479
unification of variable names, solving dependency issue
Nov 4, 2025
a5d766a
add pose_variation metric
Nov 4, 2025
c17f58a
A2 boards for lab
Nov 4, 2025
874d8a5
migrate pose_varation exposure from topic to logs
Nov 5, 2025
573da51
Refactor aruco parameters structure and update usage in ExtrinsicCali…
Nov 5, 2025
0e21500
fix
Nov 6, 2025
6793b78
pre commit
Nov 12, 2025
0782d85
pre commit
Nov 12, 2025
78c98a6
pre commit
Nov 12, 2025
8a8462b
add git lfs
Nov 12, 2025
ca21048
many minor fixes
Nov 12, 2025
1e6d93f
adding BOARD_ID logic
Nov 12, 2025
de51883
automate generator script to make filenames keep convention. Created …
Nov 13, 2025
3cdf38f
diffrent directories for diffrent classes
Nov 13, 2025
e839653
add enum class to differ board modes
Nov 13, 2025
496da67
delete unnecessary Aruco Params classes. Using classes auto-created b…
Nov 13, 2025
7617be5
parametrizing ros namespace
Nov 13, 2025
a45e599
better name for python parameters class
Nov 13, 2025
43605a4
helper functions, delete unneeded parameter - ros namespace
Nov 14, 2025
76ad540
adding parameter validation
Nov 14, 2025
01d85e7
add better metric calculation logic and logging
Nov 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
*.svg filter=lfs diff=lfs merge=lfs -text
*.png filter=lfs diff=lfs merge=lfs -text
51 changes: 51 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-added-large-files
args: ["--maxkb=10000"]
- id: debug-statements

- repo: https://github.com/psf/black
rev: 24.8.0
hooks:
- id: black

- repo: https://github.com/PyCQA/flake8
rev: 7.0.0
hooks:
- id: flake8
args: ["--max-line-length=120", "--ignore=E501,E203,W503,E741"]
language_version: python3

- repo: https://github.com/pycqa/isort
rev: 5.12.0
hooks:
- id: isort
args: ["--profile=black"]

- repo: https://github.com/asottile/pyupgrade
rev: v3.17.0
hooks:
- id: pyupgrade
args: [--py36-plus]

- repo: https://github.com/pre-commit/mirrors-clang-format
rev: v18.1.4
hooks:
- id: clang-format
files: \.(cpp|h|cc|cxx|hpp|hxx)$
args: ["--style=file"]

- repo: https://github.com/cheshirekow/cmake-format-precommit
rev: v0.6.10
hooks:
- id: cmake-format
- id: cmake-lint
args:
- "--disabled-codes=C0301" # Disable Line too long lint
- "--suppress-decorations"
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ colcon build
## Author Information

**Authors:**
- [Josep Rueda Collell](mailto:rueda_999@hotmail.com)
- [Josep Rueda Collell](mailto:rueda_999@hotmail.com)
- [Ander Gonzalez](mailto:ander.gonzalez@ikelan.es)

**Created:** October 2024
Expand All @@ -44,7 +44,7 @@ colcon build
<img src="https://github.com/user-attachments/assets/41cb9091-52c5-4f90-bbc9-ec02814dee49" alt="setup_paint" width="40%"/>

### Citation
If you use this code, please cite:
If you use this code, please cite:
**Josep Rueda Collell**. "ROS2 Extrinsic Camera Calibrator using ArUco Markers". (2024).

---
Expand Down Expand Up @@ -72,4 +72,4 @@ This software is provided under a dual license system. You may choose between:
- **GNU Affero General Public License v3**: For open-source development, subject to the conditions of this license.
- **Commercial License**: For proprietary use. For more details on the commercial license, please contact us at [info@ikerlan.es](mailto:info@ikerlan.es).

Please see the [LICENSE](./license.md) file for the complete terms and conditions of each license option.
Please see the [LICENSE](./license.md) file for the complete terms and conditions of each license option.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're storing large files, please create .gitattribute file with corresponding definition to avoid lfs in git history

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added pre-commit and git lfs

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading