forked from szknowak/extrinsic_calibrator
-
Notifications
You must be signed in to change notification settings - Fork 0
ChArUco and Aruco board based calibration #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
szknowak
wants to merge
35
commits into
humble
Choose a base branch
from
develop
base: humble
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
8506300
added logs and /robotic_platform prefix for topics
szknowak eef7bd8
initial
szknowak 87c3588
parameters descriptions
szknowak 6894a66
revert to main status
szknowak 17f76a4
parameter print
szknowak 8962bda
Board pose estimation
szknowak edab9d7
remove usused parameters
szknowak d66705e
Created script to generate aruco grids, working grid based calibration
szknowak 53544a1
revert not needed changes
szknowak ac44925
revert not needed changes
szknowak 65a7e85
added generating boards in .svg format, generated a few example aruco…
szknowak 9597267
Charuco board generation:
szknowak d456e41
Refactor camera classes for handling 3 methods of calibration in a mo…
7c839a0
revert changes from previous logic which inquired idea od preforming …
b231479
unification of variable names, solving dependency issue
a5d766a
add pose_variation metric
c17f58a
A2 boards for lab
874d8a5
migrate pose_varation exposure from topic to logs
573da51
Refactor aruco parameters structure and update usage in ExtrinsicCali…
0e21500
fix
6793b78
pre commit
0782d85
pre commit
78c98a6
pre commit
8a8462b
add git lfs
ca21048
many minor fixes
1e6d93f
adding BOARD_ID logic
de51883
automate generator script to make filenames keep convention. Created …
3cdf38f
diffrent directories for diffrent classes
e839653
add enum class to differ board modes
496da67
delete unnecessary Aruco Params classes. Using classes auto-created b…
7617be5
parametrizing ros namespace
a45e599
better name for python parameters class
43605a4
helper functions, delete unneeded parameter - ros namespace
76ad540
adding parameter validation
01d85e7
add better metric calculation logic and logging
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| *.svg filter=lfs diff=lfs merge=lfs -text | ||
| *.png filter=lfs diff=lfs merge=lfs -text |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # See https://pre-commit.com for more information | ||
| # See https://pre-commit.com/hooks.html for more hooks | ||
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.6.0 | ||
| hooks: | ||
| - id: trailing-whitespace | ||
| - id: end-of-file-fixer | ||
| - id: check-added-large-files | ||
| args: ["--maxkb=10000"] | ||
| - id: debug-statements | ||
|
|
||
| - repo: https://github.com/psf/black | ||
| rev: 24.8.0 | ||
| hooks: | ||
| - id: black | ||
|
|
||
| - repo: https://github.com/PyCQA/flake8 | ||
| rev: 7.0.0 | ||
| hooks: | ||
| - id: flake8 | ||
| args: ["--max-line-length=120", "--ignore=E501,E203,W503,E741"] | ||
| language_version: python3 | ||
|
|
||
| - repo: https://github.com/pycqa/isort | ||
| rev: 5.12.0 | ||
| hooks: | ||
| - id: isort | ||
| args: ["--profile=black"] | ||
|
|
||
| - repo: https://github.com/asottile/pyupgrade | ||
| rev: v3.17.0 | ||
| hooks: | ||
| - id: pyupgrade | ||
| args: [--py36-plus] | ||
|
|
||
| - repo: https://github.com/pre-commit/mirrors-clang-format | ||
| rev: v18.1.4 | ||
| hooks: | ||
| - id: clang-format | ||
| files: \.(cpp|h|cc|cxx|hpp|hxx)$ | ||
| args: ["--style=file"] | ||
|
|
||
| - repo: https://github.com/cheshirekow/cmake-format-precommit | ||
| rev: v0.6.10 | ||
| hooks: | ||
| - id: cmake-format | ||
| - id: cmake-lint | ||
| args: | ||
| - "--disabled-codes=C0301" # Disable Line too long lint | ||
| - "--suppress-decorations" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
710 changes: 710 additions & 0 deletions
710
example_boards/aruco_boards/A2_aruco_8x6_mar_len_05_sep_len_0125_DICT6X6_1000.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
352 changes: 352 additions & 0 deletions
352
example_boards/aruco_boards/A3_aruco_6x4_mar_len_05_sep_len_0125_DICT6X6_1000.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
174 changes: 174 additions & 0 deletions
174
example_boards/aruco_boards/A4_aruco_4x3_mar_len_05_sep_len_0125_DICT6X6_1000.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
97 changes: 97 additions & 0 deletions
97
...boards/charuco_boards/A2/A2_charuco_4x3_mar_len_006_sq_len_012_DICT6X6_1000.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're storing large files, please create
.gitattributefile with corresponding definition to avoid lfs in git historyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added pre-commit and git lfs