Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor constant USER_ID #584

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor constant USER_ID #584

wants to merge 3 commits into from

Conversation

Tristan-WorkGH
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH commented Jun 10, 2024 •
edited
Loading

  • Use HEADER_USER_ID constant
  • Separate HTTP from Event constants headers name
  • [Sonar] Use constant for repetitive value (separated in Refactor constant USER_ID (bis) #585 to better see modifications)

@Tristan-WorkGH Tristan-WorkGH self-assigned this Jun 10, 2024
@Tristan-WorkGH Tristan-WorkGH changed the title Refactor/const user Refactor constant USER_ID Jun 10, 2024
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Jun 10, 2024
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Tristan-WorkGH added a commit that referenced this pull request Jun 10, 2024
@Tristan-WorkGH
Move to PR #584 + #585
599b188
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMaskedTurtle TheMaskedTurtle Awaiting requested review from TheMaskedTurtle

At least 1 approving review is required to merge this pull request.

Assignees

@Tristan-WorkGH Tristan-WorkGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tristan-WorkGH