Prettier test reports #72
Merged
+62
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesreprise
commented
Nov 7, 2025
| (defn -main [& args] | ||
| (assert (string? (first args)) (print-str "first argument must be a string, got" args)) | ||
| (let [the-ns (-> args first symbol)] | ||
| (println "testing" the-ns) |
Member
Author
There was a problem hiding this comment.
This line is redundant, see that pretty-report for :begin-test-ns already does this.
INFO: From Testing //test:clj_kondo_test.test:
==================== Test output for //test:clj_kondo_test.test:
testing clj-kondo-test
Testing clj-kondo-test
jamesreprise
commented
Nov 7, 2025
| (zero? (:error test-report))) | ||
| (System/exit 0) | ||
| (System/exit 1))) | ||
| (binding [c.test/report pretty-report] |
Member
Author
There was a problem hiding this comment.
The clojure.test namespace advises rebinding report to achieve this functionality. https://github.com/clojure/clojure/blob/master/src/clj/clojure/test.clj#L211-L212
Comment on lines
-7
to
-14
| (def old-handler | ||
| (Signal/handle | ||
| (Signal. "TERM") | ||
| (reify SignalHandler | ||
| (handle [_ signal] | ||
| (run! println (.dumpAllThreads (ManagementFactory/getThreadMXBean) true true)) | ||
| (when-not (#{SignalHandler/SIG_DFL SignalHandler/SIG_IGN} old-handler) | ||
| (.handle old-handler signal)))))) |
Member
Author
There was a problem hiding this comment.
This didn't appear to be used anywhere.
arohner
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've overridden the default report functionality that Clojure's
clojure.testnamespace provides to print more easily readable values, especially when those values are maps.