More bugfixes #74
Open
More bugfixes #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohner
force-pushed
the
speed-fixes
branch
2 times, most recently
from
d8ae825 to
3dc9f9c
Compare
miridius
approved these changes
Dec 3, 2025
Comment on lines
115
to
119
| (map (fn [[k1 v1]] | ||
| (when-let [[_k2 v2] (find larger k1)] | ||
| (when (not= v1 v2) | ||
| [k1 [v1 v2]])))) | ||
| (filter identity)))) |
There was a problem hiding this comment.
⛳ map + filter identity = keep
Suggested change
| (map (fn [[k1 v1]] | |
| (when-let [[_k2 v2] (find larger k1)] | |
| (when (not= v1 v2) | |
| [k1 [v1 v2]])))) | |
| (filter identity)))) | |
| (keep (fn [[k1 v1]] | |
| (when-let [[_k2 v2] (find larger k1)] | |
| (when (not= v1 v2) | |
| [k1 [v1 v2]]))))))) |
arohner
force-pushed
the
speed-fixes
branch
3 times, most recently
from
ebf98d4 to
e037150
Compare
- When determining whether two classloaders are compatible?, also check for java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinism - gen_build: Make clojure_library targets depend on clojure.core.specs.alpha rather than clojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks. - minor comments and code golfing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More bug fixes after #70 and #73
compatible?, also check java class names, not just clj namespaces. This identifies JarHell as a major source of compile errors and non-determinismclojure_librarytargets depend onclojure.core.specs.alpharather thanclojure.core. This fixes a bug where clojure.core.specs.alpha gets compiled into user jars, causing false positives in compatibility checks.