Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dftd4 tests by updating to more recent version #1085

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix dftd4 tests by updating to more recent version #1085

merged 1 commit into from
Aug 12, 2024

Conversation

marcelmbn
Copy link
Member

Take more recent dftd4 version to prevent tests from failing.

[wrap-git]
directory = dftd4
url = https://github.com/dftd4/dftd4
revision = v3.6.0

@marcelmbn
fix dftd4 tests by updating to more recent version
3d476d7 
Signed-off-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
@marcelmbn marcelmbn added easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project library: dftd4 labels Aug 12, 2024
@marcelmbn marcelmbn self-assigned this Aug 12, 2024
@marcelmbn marcelmbn marked this pull request as ready for review August 12, 2024 09:09
@marcelmbn marcelmbn requested a review from Albkat August 12, 2024 09:09
@marcelmbn marcelmbn linked an issue Aug 12, 2024 that may be closed by this pull request
Some tests fail with gcc13 and higher #1083
Closed
@marcelmbn marcelmbn merged commit 5800488 into grimme-lab:main Aug 12, 2024
13 checks passed
@marcelmbn marcelmbn deleted the fix/dftd4-tests branch August 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Albkat Albkat Albkat approved these changes

Assignees

@marcelmbn marcelmbn

Labels
easy to fix This issue has a low difficulty and little entry-barrier, great to get started with this project library: dftd4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests fail with gcc13 and higher
2 participants
@marcelmbn @Albkat