Add support for no_std #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change as it changes the HasContext trait. Signed-off-by: John Nunley <dev@notgull.net>
|
The CI runners are a bit old so they'll time out here - need to get these fixed |
|
Looks like the CI runners just up and failed |
grovesNL
reviewed
Oct 10, 2023
| @@ -27,11 +27,15 @@ name = "glow" | |||
| path = "src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| ahash = { version = "0.8.3", default-features = false } | |||
There was a problem hiding this comment.
These should be optional when targeting std
|
Closing for now, as rebasing it would take some work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change as it changes the HasContext trait.
Closes #205