Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Move https://github.com/grpc-ecosystem/go-grpc-prometheus as another provider. Deprecate repo. #346

Closed
bwplotka opened this issue Oct 2, 2020 · 4 comments
Closed

v2: Move https://github.com/grpc-ecosystem/go-grpc-prometheus as another provider. Deprecate repo. #346

bwplotka opened this issue Oct 2, 2020 · 4 comments
Labels
v2

Comments

@bwplotka
Copy link
Collaborator

bwplotka commented Oct 2, 2020

This was discussed initially with @brancz #275 (comment)

I think the decision is to incorporate this Prometheus middleware here.

Not a blocker for first v2 release.
@bwplotka bwplotka added the v2 label Oct 2, 2020
@brancz
Copy link

brancz commented Oct 2, 2020

Feel free to archive the other repo once this is done I would say.

@ash2k
Copy link
Contributor

ash2k commented Oct 6, 2020

I'm looking forward to using the refreshed integration!

@bwplotka bwplotka mentioned this issue Dec 30, 2020
Open
@bwplotka
Copy link
Collaborator Author

bwplotka commented Jan 7, 2021

cc @yashrsharma44

@yashrsharma44 yashrsharma44 mentioned this issue Jan 14, 2021
Merged
4 tasks
@yashrsharma44
Copy link
Collaborator

This issue for addressed by #379 closing this hence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ash2k @brancz @bwplotka @yashrsharma44