Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify default channel factory to add support for 'null' schemes #448

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Modify default channel factory to add support for 'null' schemes #448

wants to merge 1 commit into from

Conversation

ST-DDT
Copy link
Collaborator

@ST-DDT ST-DDT commented Nov 2, 2020

Fixes #419

TODO:

  • none client/channel address scheme
  • none client/channel address (Optional)
  • none server address
  • Deprecate server port = -1 feature

TBD:
Not sure about none or null yet.

@ST-DDT ST-DDT added the enhancement A feature request or improvement label Nov 2, 2020
@ST-DDT ST-DDT added this to the 2.11.0 milestone Nov 2, 2020
@ST-DDT ST-DDT self-assigned this Nov 2, 2020
@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Nov 2, 2020

Well I should probably read the issue completely first, before starting to implement it...
->
TODO: rewrite it to match: https://github.com/yidongnan/grpc-spring-boot-starter/issues/419#issuecomment-683626998

@ST-DDT ST-DDT modified the milestones: 2.11.0, 2.12.0 Feb 7, 2021
@ST-DDT ST-DDT force-pushed the channelfactory/none branch from b3f84d1 to 5dc1d77 Compare February 7, 2021 12:20
@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Feb 7, 2021

Updated to fix conflicts, but I will delay this PR to the next milestone.

@ST-DDT ST-DDT modified the milestones: 2.12.0, 2.13.0 Apr 25, 2021
@ST-DDT ST-DDT force-pushed the channelfactory/none branch from 5dc1d77 to c00dc7a Compare November 24, 2021 20:44
@ST-DDT ST-DDT modified the milestones: 2.13.0, 2.14.0 Nov 25, 2021
@ST-DDT ST-DDT mentioned this pull request Oct 7, 2022
Closed
@ST-DDT ST-DDT modified the milestones: 2.14.0, 2.15.0 Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

Support *not* autoconfiguring client and server when address starts with "none"
1 participant
@ST-DDT