Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc_or_grpcweb.dart: exporting shared types #486 #487

Merged
merged 5 commits into from
Jun 13, 2021
Merged

grpc_or_grpcweb.dart: exporting shared types #486 #487

merged 5 commits into from
Jun 13, 2021

Conversation

gawmanarnar
Copy link
Contributor

Export shared types to prevent needing to include the grpc.dart/grpc-web.dart files conditionally

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 10, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@mraleph
Copy link
Member

mraleph commented Jun 10, 2021

@gawmanarnar please fix CLA - otherwise we can't land this.

mraleph
mraleph reviewed Jun 10, 2021
View reviewed changes
lib/grpc_or_grpcweb.dart Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 10, 2021
@mraleph
Copy link
Member

mraleph commented Jun 10, 2021

Ready to land! Thanks for the contribution @gawmanarnar!

@gawmanarnar gawmanarnar mentioned this pull request Jun 13, 2021
Closed
@mraleph mraleph merged commit f23070e into grpc:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraleph mraleph mraleph left review comments

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gawmanarnar @mraleph