Call Complete on SubchannelCallTracker after HttpContent has been disposed #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Khazuar
force-pushed
the
subchannel-call-tracker+streaming
branch
from
73a2b9a to
9b5fa3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2133
As described in that issue, the
SubchannelCallTracker.Completemethod is currently called right after the request headers are sent to the server. This does not actually correspond to the full length of the call, especially in streaming calls.This change uses a wrapped
HttpContent(like here, but only onDispose) to detect when the user code is actually done with the response data.I have tested the change with our own application and it behaves as expected. I am aware that it causes some additional allocations and a virtual method call (performance impact), but it's only relevant for users of the
ISubchannelCallTracker-interface, which is only used by some (!) custom load balancers. Given that these will not have worked correctly so far, I'd wager the cost acceptable to consider this quick fix for now, and improve on the performance later.