From 2dd0b00397b94932d3a662b5eaf2a872a87c6f54 Mon Sep 17 00:00:00 2001 From: Nick Jones Date: Wed, 30 Jan 2019 09:39:46 +1100 Subject: [PATCH] fix: envconfig.RequireHandshake initialization when `on`. https://github.com/grpc/grpc-go/commit/6cc789b34b72d30116d6139ae4af87d5bfc91478 made `envconfig.RequireHandshakeOn` the default when unspecified by environment variable, but missed a fallthrough leading to `GRPC_GO_REQUIRE_HANDSHAKE=on` specifying `envconfig.RequireHandshakeHybrid`. --- internal/envconfig/envconfig.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/envconfig/envconfig.go b/internal/envconfig/envconfig.go index d2193b3a21bb..62ed0f2f1200 100644 --- a/internal/envconfig/envconfig.go +++ b/internal/envconfig/envconfig.go @@ -59,6 +59,7 @@ var ( func init() { switch strings.ToLower(os.Getenv(requireHandshakeStr)) { case "on": + fallthrough default: RequireHandshake = RequireHandshakeOn case "off":