-
Notifications
You must be signed in to change notification settings - Fork 4.6k
deps: update golang.org/x/net to v0.47.0 (tagged version) #8732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
647d2c0 to
2c43dee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8732 +/- ##
==========================================
- Coverage 83.30% 83.28% -0.03%
==========================================
Files 419 419
Lines 32450 32450
==========================================
- Hits 27033 27025 -8
- Misses 4039 4046 +7
- Partials 1378 1379 +1 🚀 New features to boost your workflow:
|
851c8ff to
13561f2
Compare
commit 363018c updated the golang.org/x/net dependency to unclude some changes that had not yet been released. Now that v0.47.0 was released, we can switch back to released versions. full diff: golang/net@63d1a51...v0.47.0 RELEASE NOTES: N/A Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
13561f2 to
ce83f19
Compare
arjan-bal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We usually bump all dependencies every 6 weeks after cutting release branches. @thaJeztah, were you facing any issues with the version of x/net used by gRPC?
arjan-bal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a second reviewer.
No immediate issue; I noticed that un-tagged versions started to show up in various projects I maintain, so I started looking where they originated from (usually they come from smaller projects where someone accidentally did an update to Where possible, we try to stick to released versions mostly for hygiene, but also because Go's pseudo-versions don't work well with dependencies that use release branches (in which case a version may actualy be "higher" than a tagged release, and there's a risk of go modules downgrading them).
Yes, that makes sense; even for those, it may be good to only update if there's a need; go modules are designed around MVS (Minimum Version Selection) and for library modules it's good to keep versions low if there's no need to update; this can help project that maintain release branches of their own. Often we run into situations where a bugfix that's relevant (but only available in the latest version) also forces us to take a gazillion other dependency updates, which now makes it much more risky to do. Keeping required versions low allows projects to decide whether they want to update other dependencies (where needed), instead of being forced to. |
commit 363018c updated the golang.org/x/net dependency to unclude some changes that had not yet been released. Now that v0.47.0 was released, we can switch back to released versions.
full diff: golang/net@63d1a51...v0.47.0
RELEASE NOTES: N/A