Skip to content

Conversation

@thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Dec 1, 2025

commit 363018c updated the golang.org/x/net dependency to unclude some changes that had not yet been released. Now that v0.47.0 was released, we can switch back to released versions.

full diff: golang/net@63d1a51...v0.47.0

RELEASE NOTES: N/A

@thaJeztah thaJeztah changed the title go.mod: update golang.org/x/net to v0.47.0 (tagged version) deps: update golang.org/x/net to v0.47.0 (tagged version) Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.28%. Comparing base (749af0c) to head (ce83f19).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8732      +/-   ##
==========================================
- Coverage   83.30%   83.28%   -0.03%     
==========================================
  Files         419      419              
  Lines       32450    32450              
==========================================
- Hits        27033    27025       -8     
- Misses       4039     4046       +7     
- Partials     1378     1379       +1     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah thaJeztah force-pushed the x_net_tagged branch 3 times, most recently from 851c8ff to 13561f2 Compare December 1, 2025 11:06
commit 363018c updated the golang.org/x/net
dependency to unclude some changes that had not yet been released. Now that
v0.47.0 was released, we can switch back to released versions.

full diff: golang/net@63d1a51...v0.47.0

RELEASE NOTES: N/A

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Contributor Author

/cc @dfawley @easwars

@arjan-bal arjan-bal self-assigned this Dec 2, 2025
@arjan-bal arjan-bal self-requested a review December 2, 2025 06:25
@arjan-bal arjan-bal added the Type: Dependencies Updating/adding/removing dependencies label Dec 2, 2025
@arjan-bal arjan-bal added this to the 1.78 Release milestone Dec 2, 2025
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We usually bump all dependencies every 6 weeks after cutting release branches. @thaJeztah, were you facing any issues with the version of x/net used by gRPC?

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a second reviewer.

@arjan-bal arjan-bal requested a review from mbissa December 2, 2025 06:28
@arjan-bal arjan-bal assigned mbissa and unassigned arjan-bal Dec 2, 2025
@thaJeztah
Copy link
Contributor Author

were you facing any issues with the version of x/net used by gRPC?

No immediate issue; I noticed that un-tagged versions started to show up in various projects I maintain, so I started looking where they originated from (usually they come from smaller projects where someone accidentally did an update to master / main of a dependency).

Where possible, we try to stick to released versions mostly for hygiene, but also because Go's pseudo-versions don't work well with dependencies that use release branches (in which case a version may actualy be "higher" than a tagged release, and there's a risk of go modules downgrading them).

We usually bump all dependencies every 6 weeks after cutting release branches

Yes, that makes sense; even for those, it may be good to only update if there's a need; go modules are designed around MVS (Minimum Version Selection) and for library modules it's good to keep versions low if there's no need to update; this can help project that maintain release branches of their own. Often we run into situations where a bugfix that's relevant (but only available in the latest version) also forces us to take a gazillion other dependency updates, which now makes it much more risky to do. Keeping required versions low allows projects to decide whether they want to update other dependencies (where needed), instead of being forced to.

@arjan-bal arjan-bal merged commit 647162c into grpc:master Dec 4, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Dependencies Updating/adding/removing dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants