Carthage Support

[soffes]

It would be fantastic if you had Carthage support with pre-built binaries ❤️

[timburks]

Noted - thanks!

[slessans]

Any insight into how to do this would be greatly appreciated -- currently having lots of trouble trying to use this library from an iOS application.

[noppoMan]

@timburks @soffes
Hi, I tried to install grpc-swift via Carthage and it worked fine on my iPhone 7 plus.
(I also successfully archived/exported(ipa) and installed from ad-hoc with following flows)

Cartfile

github "apple/swift-protobuf" "0.9.24"
github "grpc/grpc-swift" "0.1.10"

and execute carthage update --platform iOS

Adding Header Search Paths for CgRPC

$(SRCROOT)/Carthage/Checkouts/grpc-swift/Sources/CgRPC/include

Link Binary With Libraries Phase

Run Script Phase

Check this out If you are interested.
Actually I'm gonna use grpc-swift on my both of server and iOS project!

[ebriney]

But there is no mac target though:

*** Skipped building grpc-swift due to the error:
Dependency "grpc-swift" has no shared framework schemes for any of the platforms: Mac

If you believe this to be an error, please file an issue with the maintainers at https://github.com/grpc/grpc-swift/issues/new

[noppoMan]

@ebriney
Currently grpc-swift does not have .xcodeproj cause this is a SPM library. (It means this is not be able to install via Carthage)
If you wanna install this with Carthage, folk this and add xcodeproj with swift package generate-xcodeproj.

Or Try this https://github.com/noppoMan/grpc-swift
It has a xcodeproj that include some extra settings for iOS building and can install via Carthage.

[ebriney]

Thanks, I will try that.

[willks]

@noppoMan Thanks for your fork - I'm using it and it's very easy to get going thanks to the Carthage support! Cheers

[agirault]

Or Try this https://github.com/noppoMan/grpc-swift

@noppoMan: it seems @timburks showed interest. Therefore, would it make sense to create a PR with the xcodeproj to allow to use Carthage out of the box? Would that package the headers to avoid adding the CgRPC include directory to the Header Search Paths ?

[shakesVan]

@noppoMan Thank you.
Cartfile

github "apple/swift-protobuf"
github "grpc/grpc-swift"

execute carthage update --platform iOS
I can't get grpc frameworks. Do you know why?

[MikeSilvis]

@timburks any update on this? It would help immensely for developing iOS apps

[SebastianThiebaud]

I would love to see Carthage support for grpc-swift. Any update on this? I'd love to help if needed.

[SebastianThiebaud]

@timburks We got a working fork for Carthage, but that implies some changes if we want the main repository https://github.com/grpc/grpc-swift to support Carthage. I don't know what's your position about supporting Carthage but I'd strongly encourage to enable it (more adoption of grpc-swift can only lead to a better quality of the library and more hands to help). I could help to get grpc-swift ready for Carthage. The only blocker that I see at the moment is related to CZlib. The dependency used (https://github.com/ZewoGraveyard/CZlib) wouldn't work at this point with Carthage. I also realized that this dependency hasn't been updated for over 2 years. Could we assume it won't be updated anymore and directly include the source code in this repository? If that's not something that seems good to you, we could make CZlib working with Carthage too.

[MrMage]

Would another option be to simply avoid including zlib in your Carthage spec? For example, in my grpc-swift Podspec I include the necessary dependencies as other Pods instead of using any of the SPM packages or the vendored code. Given that zlib should be available on the Carthage-supported platforms anyway, maybe that would be another option?

Actually, thinking more about this, is the zlib dependency still needed at all? With a cursory look through the framework, I can't find any code dependencies on zlib.

[SebastianThiebaud]

If we can confirm that zlib isn't needed, that would be great.