Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove adding callback_guard" #559

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

EPashkin
Copy link
Member

@EPashkin EPashkin commented Mar 2, 2018

This reverts commit a61ccc1.

Part of gtk-rs/glib#250

cc @GuillaumeGomez, @sdroege

@EPashkin
Copy link
Member Author

EPashkin commented Mar 2, 2018

Or better add config for this?

@GuillaumeGomez
Copy link
Member

A default cfg! maybe?

@EPashkin
Copy link
Member Author

EPashkin commented Mar 2, 2018

@GuillaumeGomez Sorry, I don't understand.

@GuillaumeGomez
Copy link
Member

I meant we added a new feature (in Cargo.toml) and it was a default one so it can be disabled. Better? :)

@EPashkin
Copy link
Member Author

EPashkin commented Mar 2, 2018

This way gir with from same commit can produce different result.
Not sure that it good idea.
Hm. I wrong, you can't change features in Cargo.toml without adding new commit (ignoring --no-default-features flag).
I don't see difference without this and just adding commit.
I meant adding option to Gir.toml.

@EPashkin
Copy link
Member Author

EPashkin commented Mar 2, 2018

.. but as "my" option in "Gir.toml" will be used only year or half maybe it unnecessary work.

@GuillaumeGomez
Copy link
Member

I suppose... Let's just revert everything and avoid any unnecessary work.

@EPashkin EPashkin merged commit fbb95f4 into gtk-rs:master Mar 2, 2018
@EPashkin EPashkin deleted the restore_callback_guard branch March 2, 2018 18:41
@sdroege
Copy link
Member

sdroege commented Mar 2, 2018

Yes, revert simply and then we revert the reverts in 1-2 months again.

vhdirk pushed a commit to vhdirk/gir that referenced this pull request Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants