Skip to content

Conversation

@A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Nov 27, 2025

Supersedes: #2182

github-actions bot and others added 6 commits November 27, 2025 08:49
This reverts commit 672c388. The
required commit landed in the gir used for regenerating the files.
This reverts commit 19d1c53. The
required fix landed in gtk4 gir file.
@sdroege
Copy link
Member

sdroege commented Nov 27, 2025

IIRC there's some new node type in gsk now that needs bindings

//=========================================================================
#[cfg(feature = "v4_22")]
#[cfg_attr(docsrs, doc(cfg(feature = "v4_22")))]
pub fn gsk_render_replay_default(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs bindings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get

thread 'main' panicked at src/codegen/record.rs:34:13:
Record RenderReplay has record_boxed=true but don't have glib:get_type function
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

when regenerating with Gsk.RenderReplay.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has to be manual bindings then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because this has not a get_type function but also only has a free function and no copy function. We can't auto-generate bindings for types that have such a shape.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #2184

@sdroege
Copy link
Member

sdroege commented Nov 27, 2025

Looks good otherwise, thanks!

@bilelmoussaoui bilelmoussaoui merged commit 5ba4629 into gtk-rs:main Nov 27, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants