-
-
Notifications
You must be signed in to change notification settings - Fork 198
Changes from updating gir/gir-files #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
IIRC there's some new node type in gsk now that needs bindings |
| //========================================================================= | ||
| #[cfg(feature = "v4_22")] | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "v4_22")))] | ||
| pub fn gsk_render_replay_default( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get
thread 'main' panicked at src/codegen/record.rs:34:13:
Record RenderReplay has record_boxed=true but don't have glib:get_type function
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
when regenerating with Gsk.RenderReplay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this has to be manual bindings then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because this has not a get_type function but also only has a free function and no copy function. We can't auto-generate bindings for types that have such a shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #2184
|
Looks good otherwise, thanks! |
0351305 to
351234c
Compare
351234c to
54be5cb
Compare
Supersedes: #2182