Fix plugin auto-loading by adding a --guard flag #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minitest loads all plugins regardless of context and this caused guard notifiers to fire even when tests were run outside of guard. To fix this we pass a --guard flag to minitest and only add the Guard::Minitest::Reporter if the flag is set. Also the loading of guard related code is deferred and controlled by the --guard flag. This way guard and everything that comes with it will not be loaded outside of guard.
|
Build fails partially because of json needing Ruby >= 2, so this looks ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #137.
Minitest loads all plugins regardless of context and this caused guard notifiers to fire even when tests were run outside of guard. To fix this we pass a
--guardflag to minitest and only add theGuard::Minitest::Reporterif the flag is set.Also the loading of guard related code is deferred and controlled by the
--guardflag. This way guard and everything that comes with it will not be loaded outside of guard.Thanks @zenspider for the inspiration.