Remove redundant cookies

guardian · Dec 12, 2024 · 92b64f0 · 92b64f0
1 parent 35efa61
commit 92b64f0
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 33 deletions.
diff --git a/dotcom-rendering/src/client/userFeatures/user-features.ts b/dotcom-rendering/src/client/userFeatures/user-features.ts
@@ -27,25 +27,18 @@ import {
 import type { UserFeaturesResponse } from './user-features-lib';
 
 const USER_FEATURES_EXPIRY_COOKIE = 'gu_user_features_expiry';
-const PAYING_MEMBER_COOKIE = 'gu_paying_member';
 const ACTION_REQUIRED_FOR_COOKIE = 'gu_action_required_for';
 const DIGITAL_SUBSCRIBER_COOKIE = 'gu_digital_subscriber';
 const HIDE_SUPPORT_MESSAGING_COOKIE = 'gu_hide_support_messaging';
 const AD_FREE_USER_COOKIE = 'GU_AF1';
 
-const RECURRING_CONTRIBUTOR_COOKIE = 'gu_recurring_contributor';
-const ONE_OFF_CONTRIBUTION_DATE_COOKIE = 'gu_one_off_contribution_date';
-
 const forcedAdFreeMode = !!/[#&]noadsaf(&.*)?$/.exec(window.location.hash);
 
 const userHasData = () => {
 	const cookie =
 		getAdFreeCookie() ??
 		getCookie({ name: ACTION_REQUIRED_FOR_COOKIE }) ??
 		getCookie({ name: USER_FEATURES_EXPIRY_COOKIE }) ??
-		getCookie({ name: PAYING_MEMBER_COOKIE }) ??
-		getCookie({ name: RECURRING_CONTRIBUTOR_COOKIE }) ??
-		getCookie({ name: ONE_OFF_CONTRIBUTION_DATE_COOKIE }) ??
 		getCookie({ name: DIGITAL_SUBSCRIBER_COOKIE }) ??
 		getCookie({ name: HIDE_SUPPORT_MESSAGING_COOKIE });
 	return !!cookie;
@@ -69,14 +62,6 @@ const persistResponse = (JsonResponse: UserFeaturesResponse) => {
 		name: USER_FEATURES_EXPIRY_COOKIE,
 		value: timeInDaysFromNow(1),
 	});
-	setCookie({
-		name: PAYING_MEMBER_COOKIE,
-		value: String(JsonResponse.contentAccess.paidMember),
-	});
-	setCookie({
-		name: RECURRING_CONTRIBUTOR_COOKIE,
-		value: String(JsonResponse.contentAccess.recurringContributor),
-	});
 	setCookie({
 		name: DIGITAL_SUBSCRIBER_COOKIE,
 		value: String(JsonResponse.contentAccess.digitalPack),
@@ -85,12 +70,6 @@ const persistResponse = (JsonResponse: UserFeaturesResponse) => {
 		name: HIDE_SUPPORT_MESSAGING_COOKIE,
 		value: String(!JsonResponse.showSupportMessaging),
 	});
-	if (JsonResponse.oneOffContributionDate) {
-		setCookie({
-			name: ONE_OFF_CONTRIBUTION_DATE_COOKIE,
-			value: JsonResponse.oneOffContributionDate,
-		});
-	}
 
 	removeCookie({ name: ACTION_REQUIRED_FOR_COOKIE });
 	if (JsonResponse.alertAvailableFor) {
@@ -110,12 +89,9 @@ const persistResponse = (JsonResponse: UserFeaturesResponse) => {
 const deleteOldData = (): void => {
 	removeCookie({ name: AD_FREE_USER_COOKIE });
 	removeCookie({ name: USER_FEATURES_EXPIRY_COOKIE });
-	removeCookie({ name: PAYING_MEMBER_COOKIE });
-	removeCookie({ name: RECURRING_CONTRIBUTOR_COOKIE });
 	removeCookie({ name: ACTION_REQUIRED_FOR_COOKIE });
 	removeCookie({ name: DIGITAL_SUBSCRIBER_COOKIE });
 	removeCookie({ name: HIDE_SUPPORT_MESSAGING_COOKIE });
-	removeCookie({ name: ONE_OFF_CONTRIBUTION_DATE_COOKIE });
 };
 
 const requestNewData = () => {

diff --git a/dotcom-rendering/src/lib/contributions.ts b/dotcom-rendering/src/lib/contributions.ts
@@ -16,11 +16,7 @@ export const HIDE_SUPPORT_MESSAGING_COOKIE = 'gu_hide_support_messaging';
 export const RECURRING_CONTRIBUTOR_COOKIE = 'gu_recurring_contributor';
 export const OPT_OUT_OF_ARTICLE_COUNT_COOKIE = 'gu_article_count_opt_out';
 
-// Support Frontend cookies (created when a contribution is made)
-export const SUPPORT_RECURRING_CONTRIBUTOR_MONTHLY_COOKIE =
-	'gu.contributions.recurring.contrib-timestamp.Monthly'; // TODO: delete this, no longer needed
-export const SUPPORT_RECURRING_CONTRIBUTOR_ANNUAL_COOKIE =
-	'gu.contributions.recurring.contrib-timestamp.Annual'; // TODO: delete this, no longer needed
+// Support Frontend cookie (created when a contribution is made)
 export const SUPPORT_ONE_OFF_CONTRIBUTION_COOKIE =
 	'gu.contributions.contrib-timestamp';
 

diff --git a/dotcom-rendering/src/lib/readerRevenueDevUtils.ts b/dotcom-rendering/src/lib/readerRevenueDevUtils.ts
@@ -3,16 +3,12 @@ import {
 	HIDE_SUPPORT_MESSAGING_COOKIE,
 	RECURRING_CONTRIBUTOR_COOKIE,
 	SUPPORT_ONE_OFF_CONTRIBUTION_COOKIE,
-	SUPPORT_RECURRING_CONTRIBUTOR_ANNUAL_COOKIE,
-	SUPPORT_RECURRING_CONTRIBUTOR_MONTHLY_COOKIE,
 } from './contributions';
 import { getLocaleCode } from './getCountryCode';
 
 const readerRevenueCookies = [
 	HIDE_SUPPORT_MESSAGING_COOKIE,
 	RECURRING_CONTRIBUTOR_COOKIE,
-	SUPPORT_RECURRING_CONTRIBUTOR_MONTHLY_COOKIE,
-	SUPPORT_RECURRING_CONTRIBUTOR_ANNUAL_COOKIE,
 	SUPPORT_ONE_OFF_CONTRIBUTION_COOKIE,
 ];