From fb30970e3ded75f56b098b7538a5cdc7b433b76a Mon Sep 17 00:00:00 2001 From: George B <705427+georgeblahblah@users.noreply.github.com> Date: Tue, 20 Jun 2023 10:29:09 +0100 Subject: [PATCH] update node to 18.16.0 (#7948) --- .nvmrc | 2 +- apps-rendering/package.json | 2 +- apps-rendering/riff-raff.yaml | 2 +- apps-rendering/yarn.lock | 8 ++++---- dotcom-rendering/Containerfile | 2 +- dotcom-rendering/package.json | 2 +- dotcom-rendering/scripts/deploy/riff-raff.yaml | 2 +- yarn.lock | 13 +++++++++---- 8 files changed, 19 insertions(+), 14 deletions(-) diff --git a/.nvmrc b/.nvmrc index e65243f2ea3..6d80269a4f0 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16.19.0 +18.16.0 diff --git a/apps-rendering/package.json b/apps-rendering/package.json index 6da85459fc6..89fb622b615 100644 --- a/apps-rendering/package.json +++ b/apps-rendering/package.json @@ -70,7 +70,7 @@ "@types/html-webpack-plugin": "^3.2.6", "@types/jest": "^28.1.6", "@types/jsdom": "^16.2.13", - "@types/node": "^14.17.19", + "@types/node": "18.16.0", "@types/react": "^18.2.0", "@types/react-dom": "^18.2.0", "@types/react-test-renderer": "^18.0.0", diff --git a/apps-rendering/riff-raff.yaml b/apps-rendering/riff-raff.yaml index f1495b577c6..297bb3dc293 100644 --- a/apps-rendering/riff-raff.yaml +++ b/apps-rendering/riff-raff.yaml @@ -11,7 +11,7 @@ templates: amiParameter: AMIMobileappsrendering amiEncrypted: true amiTags: - Recipe: focal-mobile-node16-ARM + Recipe: jammy-mobile-node18-ARM AmigoStage: PROD deployments: mobile-apps-rendering-cfn: diff --git a/apps-rendering/yarn.lock b/apps-rendering/yarn.lock index b46dd69eb3f..3928cb96503 100644 --- a/apps-rendering/yarn.lock +++ b/apps-rendering/yarn.lock @@ -3597,10 +3597,10 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.18.tgz#8dfb97f0da23c2293e554c5a50d61ef134d7697f" integrity sha512-DHQpWGjyQKSHj3ebjFI/wRKcqQcdR+MoFBygntYOZytCqNfkd2ZC4ARDJ2DQqhjH5p85Nnd3jhUJIXrszFX/JA== -"@types/node@^14.17.19": - version "14.17.19" - resolved "https://registry.yarnpkg.com/@types/node/-/node-14.17.19.tgz#7341e9ac1b5d748d7a3ddc04336ed536a6f91c31" - integrity sha512-jjYI6NkyfXykucU6ELEoT64QyKOdvaA6enOqKtP4xUsGY0X0ZUZz29fUmrTRo+7v7c6TgDu82q3GHHaCEkqZwA== +"@types/node@18.16.0": + version "18.16.0" + resolved "https://registry.yarnpkg.com/@types/node/-/node-18.16.0.tgz#4668bc392bb6938637b47e98b1f2ed5426f33316" + integrity sha512-BsAaKhB+7X+H4GnSjGhJG9Qi8Tw+inU9nJDwmD5CgOmBLEI6ArdhikpLX7DjbjDRDTbqZzU2LSQNZg8WGPiSZQ== "@types/node@^16.0.0": version "16.18.24" diff --git a/dotcom-rendering/Containerfile b/dotcom-rendering/Containerfile index b80e669073f..254a0046551 100644 --- a/dotcom-rendering/Containerfile +++ b/dotcom-rendering/Containerfile @@ -1,5 +1,5 @@ # This container is used in our CICD pipelines for running E2E and regression tests. -FROM node:16.19.0-alpine +FROM node:18.16.0-alpine WORKDIR /opt/app/dotcom-rendering/dotcom-rendering diff --git a/dotcom-rendering/package.json b/dotcom-rendering/package.json index 3188c15f56e..29f92d02c45 100644 --- a/dotcom-rendering/package.json +++ b/dotcom-rendering/package.json @@ -120,7 +120,7 @@ "@types/lodash": "4.14.191", "@types/lodash.debounce": "4.0.7", "@types/lodash.get": "4.4.7", - "@types/node": "16.18.12", + "@types/node": "18.16.0", "@types/node-fetch": "2.6.2", "@types/prop-types": "15.7.5", "@types/qs": "6.9.7", diff --git a/dotcom-rendering/scripts/deploy/riff-raff.yaml b/dotcom-rendering/scripts/deploy/riff-raff.yaml index adccad8aca5..88a78b200f7 100755 --- a/dotcom-rendering/scripts/deploy/riff-raff.yaml +++ b/dotcom-rendering/scripts/deploy/riff-raff.yaml @@ -19,7 +19,7 @@ deployments: InstanceType: t4g.small amiParametersToTags: AMI: - Recipe: dotcom-rendering-ARM-node16 + Recipe: dotcom-rendering-ARM-jammy-node-18 BuiltBy: amigo AmigoStage: PROD rendering: diff --git a/yarn.lock b/yarn.lock index 0d0eb74710b..81979acd37c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6034,10 +6034,10 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-18.13.0.tgz#0400d1e6ce87e9d3032c19eb6c58205b0d3f7850" integrity sha512-gC3TazRzGoOnoKAhUx+Q0t8S9Tzs74z7m0ipwGpSqQrleP14hKxP4/JUeEQcD3W1/aIpnWl8pHowI7WokuZpXg== -"@types/node@16.18.12", "@types/node@^16.9.2": - version "16.18.12" - resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.12.tgz#e3bfea80e31523fde4292a6118f19ffa24fd6f65" - integrity sha512-vzLe5NaNMjIE3mcddFVGlAXN1LEWueUsMsOJWaT6wWMJGyljHAWHznqfnKUQWGzu7TLPrGvWdNAsvQYW+C0xtw== +"@types/node@18.16.0": + version "18.16.0" + resolved "https://registry.yarnpkg.com/@types/node/-/node-18.16.0.tgz#4668bc392bb6938637b47e98b1f2ed5426f33316" + integrity sha512-BsAaKhB+7X+H4GnSjGhJG9Qi8Tw+inU9nJDwmD5CgOmBLEI6ArdhikpLX7DjbjDRDTbqZzU2LSQNZg8WGPiSZQ== "@types/node@^13.7.0": version "13.13.52" @@ -6054,6 +6054,11 @@ resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.23.tgz#b6e934fe427eb7081d0015aad070acb3373c3c90" integrity sha512-XAMpaw1s1+6zM+jn2tmw8MyaRDIJfXxqmIQIS0HfoGYPuf7dUWeiUKopwq13KFX9lEp1+THGtlaaYx39Nxr58g== +"@types/node@^16.9.2": + version "16.18.12" + resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.12.tgz#e3bfea80e31523fde4292a6118f19ffa24fd6f65" + integrity sha512-vzLe5NaNMjIE3mcddFVGlAXN1LEWueUsMsOJWaT6wWMJGyljHAWHznqfnKUQWGzu7TLPrGvWdNAsvQYW+C0xtw== + "@types/normalize-package-data@^2.4.0": version "2.4.1" resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.1.tgz#d3357479a0fdfdd5907fe67e17e0a85c906e1301"