-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lastOneOffContributionDate and isRecurringContributor from payload sent to SDC #12983
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: -2.21 kB (-0.23%) Total Size: 942 kB
ℹ️ View Unchanged
|
35aaa34
to
92b64f0
Compare
export const OPT_OUT_OF_ARTICLE_COUNT_COOKIE = 'gu_article_count_opt_out'; | ||
|
||
// Support Frontend cookies (created when a contribution is made) | ||
export const SUPPORT_RECURRING_CONTRIBUTOR_MONTHLY_COOKIE = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's safe to remove these because support-frontend sets the gu_hide_support_messaging
cookie after checkout - is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly 👍
92b64f0
to
7364f73
Compare
7364f73
to
5d2f6a9
Compare
Seen on PROD (merged by @rupertbates 8 minutes and 48 seconds ago) Please check your changes! |
What does this change?
support-dotcom-components does not use the
isRecurringContributor
orlastOneOffContributionDate
values which we were passing to it. These were removed from the expected payload here so this PR updates DCR to stop sending these values.