Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cricket Players Unique Name #27464

Closed
wants to merge 8 commits into from
Closed

Cricket Players Unique Name #27464

wants to merge 8 commits into from

Commits on Sep 24, 2024

  1. Create a map of cricker players id and unique name 

    We need to be able to distinguish between bowlers and catchers that have the same surname. This is a first step to be able to know their unique name.

Co-authored-by: Roberto Tyley <52038+rtyley@users.noreply.github.com>
    @ioannakok @rtyley
    ioannakok and rtyley committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    38582a8 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for PlayerNames.uniqueNames

    @ioannakok
    ioannakok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    993b69e View commit details
    Browse the repository at this point in the history

  3. PlayerNamesTest

    @ioannakok
    ioannakok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    22bf328 View commit details
    Browse the repository at this point in the history

  4. Pass variables

    @ioannakok
    ioannakok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a7804a1 View commit details
    Browse the repository at this point in the history

  5. Get catcher and bowler ids

    @ioannakok
    ioannakok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4081b7b View commit details
    Browse the repository at this point in the history

  6. Add descriptionWithUniqueNames method

    @ioannakok
    ioannakok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    4102e0d View commit details
    Browse the repository at this point in the history

  7. Call descriptionWithUniqueNames

    @ioannakok
    ioannakok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    12a10ae View commit details
    Browse the repository at this point in the history

  8. Substitute cricket match description for certain dismissal types 

    We would like to be able to use the full name of a bowler or a catcher if two players in the same team share the same surname. We also want to leave the description as it is if there is no need for subsitution, e.g. when dismissal type is "Run Out"

Co-authored-by: Roberto Tyley <52038+rtyley@users.noreply.github.com>
    @ioannakok @rtyley
    ioannakok and rtyley committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c694556 View commit details
    Browse the repository at this point in the history