Commits on Nov 27, 2024

1. Use JsValue not String for DCAR …

   Frontend posts the data for articles, fronts, tags pages and so on to DCAR as JSON, using `WSClient`. At the moment the following steps are taken to transform from an instance of a case class in frontend to the format that `WSClient` uses (`BodyWritable`):
   
   ```
   case class instance -> JsValue -> String -> BodyWritable
   ```
   
   The final transformation here, `String -> BodyWritable`, is handled by `WSClient`, as it defines an implicit way to get from one type to the other. However, it also defines a way to do this for a `play-json` `JsValue`, so we do not need to convert to a `String` beforehand. We should be able to pass a `JsValue` to `WSClient` directly, removing one of the transformation steps:
   
   ```
   case class instance -> JsValue -> BodyWritable
   ```
   
   The way to achieve this is by modifying our methods that use `WSClient.post` to take a `JsValue` payload instead of a `String`. We are then able to update the `toJson` methods on each of our models to remove the `Json.stringify` step. However, aside from `RemoteRender` requests, these `toJson` methods are also used to provide for `JsonFormat` requests via the `renderJson` method, which at the moment requires a `String`. This method, though, makes use of Play's `Writeable`, which also includes an implicit transformation to get from a `play-json` `JsValue`. So we can update it to take a `JsValue` instead, and save the additional `String` transformation step here too.
   
   Note that there is one exception where we're using `circe` instead of `play-json`, for crosswords, so in that case we're transforming from one to the other via `String`.

   

   JamieB-gu committed Nov 27, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for f824ae2
   • Browse repository at this point

   Copy the full SHA

   f824ae2 View commit details

   Browse the repository at this point in the history