Handle more elements #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think these should both map to what composer enters for shift-enter, i.e. a `<br>` tag.
I may have got the title and link text backwards, but I don’t think so: _title here has type Text while linkText has type Inlines, which sounds like it matches the description in the manual: > The link text can contain formatting (such as emphasis), but the title > cannot.
I _think_ this should work…
This is somewhat hackish, but hopefully it works ok!
At the moment things don’t look quite right: markdown paragraphs aren’t getting wrapped into single lines. I think this is why, though I might need to also change the handling of LineBreak in the same way.
The content type used for submission needs to be application/octet-stream, for servant to accept it. (Otherwise it returns a 415.)
For converting docx, the browser sends cors preflight requests, which fail. This middleware should allow them to be answered correctly.
Now that I have automatic headers from a dependency, mine are unneeded! And causing problems with firefox, so let’s remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The converting server currently ignores many elements! For the purpose of demoing, it’d be nice for it to support some more.