-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new postcodes to valid Home Delivery postcode list #4117
Conversation
Size Change: -8 B (0%) Total Size: 1.95 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Seen on PROD (merged by @GHaberis 13 minutes and 46 seconds ago)
Sentry Release: support-client-side, support |
@GHaberis good question I did a bit of github archaeology and it looks like @rupertbates asked that question at the time and there was no answer recorded It looks like the resource used for the list of postcodes is here: https://drive.google.com/drive/u/0/folders/129MbqLqrMDueSQYbcfZMJqAHmbukKdR3 I would say just combine one list with all of them, as per the latest info from the supplier. |
What are you doing in this PR?
We can now deliver Newspapers to the following postcode districts:
AL2
GU1
GU2
GU21
GU22
EN8
IG4
KT22
N1C
This PR adds these postcode prefixes to the list of valid postcodes, which are defined in the code in
CheckoutValidationRules.scala
. The postcodes are split over two lists in the Scala fileM25_POSTCODE_OLD_PREFIXES
andM25_NEW_PREFIXES
, i'm not sure why this is, I looked at the history and couldn't see a reason (@johnduffell any idea?). Anyhow these 2 lists are concatenated and exposed to the client onwindow.guardian.homeDeliveryPostcodes
, and we validate postcodes entered in the client using this list.I've tested some of the new postcode prefixes before and after the change and can confirm adding them to the lists above means they now pass validation.
There's also a small change to the wording to remove the "(within M25)" wording.