Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new postcodes to valid Home Delivery postcode list #4117

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

GHaberis
Copy link
Contributor

@GHaberis GHaberis commented Aug 11, 2022

What are you doing in this PR?

We can now deliver Newspapers to the following postcode districts:

AL2
GU1
GU2
GU21
GU22
EN8
IG4
KT22
N1C

This PR adds these postcode prefixes to the list of valid postcodes, which are defined in the code in CheckoutValidationRules.scala. The postcodes are split over two lists in the Scala file M25_POSTCODE_OLD_PREFIXES and M25_NEW_PREFIXES, i'm not sure why this is, I looked at the history and couldn't see a reason (@johnduffell any idea?). Anyhow these 2 lists are concatenated and exposed to the client on window.guardian.homeDeliveryPostcodes, and we validate postcodes entered in the client using this list.

I've tested some of the new postcode prefixes before and after the change and can confirm adding them to the lists above means they now pass validation.

There's also a small change to the wording to remove the "(within M25)" wording.

@GHaberis GHaberis requested a review from a team August 11, 2022 16:24
@GHaberis
Copy link
Contributor Author

@github-actions
Copy link
Contributor

Size Change: -8 B (0%)

Total Size: 1.95 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/ausMomentMap.js 107 kB 0 B
./public/compiled-assets/javascripts/contributionsCheckoutInEpic.js 120 kB 0 B
./public/compiled-assets/javascripts/contributionsLandingPage.js 196 kB 0 B
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionCheckoutPage.js 160 kB 0 B
./public/compiled-assets/javascripts/digitalSubscriptionCheckoutPageThankYouExisting.js 74.2 kB 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 140 kB 0 B
./public/compiled-assets/javascripts/downForMaintenancePage.js 66.4 kB 0 B
./public/compiled-assets/javascripts/error404Page.js 66.4 kB 0 B
./public/compiled-assets/javascripts/error500Page.js 66.3 kB 0 B
./public/compiled-assets/javascripts/favicons.js 616 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 158 kB 0 B
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 85.6 kB -8 B (0%)
./public/compiled-assets/javascripts/payPalErrorPage.js 64.4 kB 0 B
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 69.8 kB 0 B
./public/compiled-assets/javascripts/showcasePage.js 83 kB 0 B
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 72.3 kB 0 B
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 114 kB 0 B
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 155 kB 0 B
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 86.2 kB 0 B
./public/compiled-assets/webpack/206.js 17.6 kB 0 B
./public/compiled-assets/webpack/249.js 20.7 kB 0 B
./public/compiled-assets/webpack/522.js 2.35 kB 0 B
./public/compiled-assets/webpack/746.js 2.22 kB 0 B
./public/compiled-assets/webpack/775.js 15.9 kB 0 B

compressed-size-action

Copy link
Contributor

@i-hardy i-hardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GHaberis GHaberis merged commit 1309200 into main Aug 15, 2022
@GHaberis GHaberis deleted the gh-enable-postcodes-hd branch August 15, 2022 08:35
@prout-bot
Copy link

Seen on PROD (merged by @GHaberis 13 minutes and 46 seconds ago)

Sentry Release: support-client-side, support

@johnduffell
Copy link
Member

@GHaberis good question I did a bit of github archaeology and it looks like @rupertbates asked that question at the time and there was no answer recorded
https://github.com/guardian/support-frontend/pull/2263/files/6107f5744ef6f0bbf28595de85f9f79d856ec7c8#r352707603

It looks like the resource used for the list of postcodes is here: https://drive.google.com/drive/u/0/folders/129MbqLqrMDueSQYbcfZMJqAHmbukKdR3

I would say just combine one list with all of them, as per the latest info from the supplier.

@graham228221 graham228221 mentioned this pull request Aug 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants