-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda: Typescript conversion bigquery-acquisitions-publisher #6787
Open
paul-daniel-dempsey
wants to merge
31
commits into
main
Choose a base branch
from
pd/bigquery-acquisitions-publisher-typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lambda: Typescript conversion bigquery-acquisitions-publisher #6787
paul-daniel-dempsey
wants to merge
31
commits into
main
from
pd/bigquery-acquisitions-publisher-typescript
+4,605
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.94 MB ℹ️ View Unchanged
|
This is better than casting without checking anything.
c6dddf8
to
94e0cab
Compare
…b.com:guardian/support-frontend into pd/bigquery-acquisitions-publisher-typescript
a920998
to
417604f
Compare
204bcbc
to
210af51
Compare
31a18d0
to
89b00db
Compare
9f0367e
to
5e5bd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Trello Card
Why are you doing this?
How to test
How can we measure success?
Have we considered potential risks?
Accessibility test checklist
Screenshots