Update to Java 17 #533
Closed
Update to Java 17 #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
commented
Sep 18, 2024
| Recipe: editorial-tools-focal-java8-ARM-WITH-cdk-base | ||
| Recipe: editorial-tools-focal-java17 |
There was a problem hiding this comment.
Choosing Java 17 here as it seems to be the most recent AMIgo image available - would have chosen a Java 21 LTS AMIgo image if it was available!
This satisfies one of the updated requirements of Panda v7 - as of guardian/pan-domain-authentication#150 it requires Java 11. See also: * guardian/maintaining-scala-projects#3 * guardian/maintaining-scala-projects#8
rtyley
force-pushed
the
update-to-java-17
branch
from
a765631
to
112b4f1
Compare
|
Closing for now as apparently running Play on Java 17 is "experimental. Tweaks are necessary: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This satisfies one of the updated requirements of Panda v7 - as of guardian/pan-domain-authentication#150, Panda requires Java 11.
See also: