-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MouseEvent
and MouseEventEventArgs
to simplify
#3029
Comments
- Started MouseEventEventArgs -> MouseEvent transition - for OnMouseEvent. Partially fixes gui-cs#3029. - Refactored Appliation.OnMouseEvent and View.OnMouseEvent to match design guidelines. - Re-impleented highlight, enabling extensibility (see Border). - Beefed up unit tests
Partially fixed in #3372. |
BTW: For adherence to the dotnet design guidelines for events, all EventArgs classes should end in "EventArgs" and should not be mixed use classes outside of events themselves (Key, for example, is used both ways - I have a stashed change somewhere that's probably way obsolete by now that fixed that). Inheriting from EventArgs also used to be recommended, but is now just a soft suggestion. Here's one of the best of the various documents about guidelines for events: |
Fixes #3029 - Refactors `MouseEvent` and APIs to simplify and make consistent
Similar in spirit, but somewhat less scope, than #2927
New/OnMouseEvent
now uses justMouseEvent
.New/OnMouseClicked
now uses justMouseEvent
.OfX
/OfY
Responder
and intoView
soResponder
can be nukeddocs/mouse.md
MouseBindings
per #Command
is too tightly coupled withKeyBindings
#3778Responder.IsOverridden
which breaks all rules of OO design.The text was updated successfully, but these errors were encountered: