Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2453. TextField OnEnter throws exception if IsInitialized is false. #2454

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 27, 2023

Fixes #2453 - Driver was accessed before IsInitialized is true.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested review from migueldeicaza and tig as code owners March 27, 2023 13:43
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

What is the code path that led to you discovering this?

I'd argue that any code path that causes a view to be "used" before IsInitialized == true is buggy.

@tig tig merged commit 33c9a5f into gui-cs:v2_develop Mar 27, 2023
@BDisp BDisp deleted the v2_textfield-onenter-fix_2453 branch March 27, 2023 15:42
@BDisp
Copy link
Collaborator Author

BDisp commented Mar 27, 2023

What is the code path that led to you discovering this?

Was in the View.Add when the ComboBox is added and CanFocus is set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants