Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2954. Modal view is always refreshing only by moving the mouse. #2958

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Nov 5, 2023

Fixes #2954 - The current and unique modal toplevel must clear all the terminal size and not only itself if it's dirty.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner November 5, 2023 21:50
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except unit tests are failing.

@BDisp
Copy link
Collaborator Author

BDisp commented Nov 6, 2023

LGTM except unit tests are failing.

It's the TestTreeViewColor again. If I run it alone it pass. I'll see what going on.

@BDisp
Copy link
Collaborator Author

BDisp commented Nov 6, 2023

LGTM except unit tests are failing.

It's the TestTreeViewColor again. If I run it alone it pass. I'll see what going on.

Fixed, I had to force shutdown on my unit test.

@tig tig merged commit e16205a into gui-cs:v2_develop Nov 7, 2023
1 check passed
@BDisp BDisp deleted the v2_modal-refreshing-fix_2954 branch November 7, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants