Implemented overwrite option in dest()
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,9 @@ function writeContents(writePath, file, cb) { | |||
| } | |||
|
|
|||
| function written(err) { | |||
| if (err) { | |||
| var ignorableError = (err && err.code === 'EEXIST' && file.flag === 'wx'); | |||
There was a problem hiding this comment.
canIgnoreError or isErrorFatal would be more descriptive imo
|
Very clean PR - one minor nitpick and I am +1 on merging this. Thanks! 🌴 |
yocontra
pushed a commit
that referenced
this pull request
Feb 23, 2015
Implemented `overwrite` option in `dest()`
|
Thanks! |
|
Available on master - will be published in the 4.0 release |
|
👍 |
|
@Narretz comments like that are not welcome here. Feel free to use the module directly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to: #30
It seemed like the overwrite option was stubbed out, but the
wxflag was never utilized in the fs operations. This commit wires it up, handles the error catch scenario and adds some tests. Let me know what you think!