Feature/review made easy #477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascheman
force-pushed
the
feature/review-made-easy
branch
from
db5cd33
to
4b48e9f
Compare
The source branch of the PR is needed, not the target branch (which is almost always "main").
by - ignoring merge abort problems - stashing/popping local changes to clean up branches
ascheman
force-pushed
the
feature/review-made-easy
branch
from
a7a3e8b
to
b68492b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These scripts support local code reviews (cf. contained README).
They are build upon other changes to facilitate tests with (large) measurement files (>= 100.000 entries) with unique measurements. The idea behind it was to detect hash function/collision errors which are more probable to occur with larger unique data sets.
But it should be possible to split these two concerns, @gunnarmorling or at least to make the execution of the unique tests optional.