Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AoBPR Implementation Typo of P(f|c) #328

Open
AaronHeee opened this issue May 26, 2020 · 0 comments
Open

AoBPR Implementation Typo of P(f|c) #328

AaronHeee opened this issue May 26, 2020 · 0 comments

Comments

@AaronHeee
Copy link

According to eq (17) in the original WSDM paper, p(f|c) is based on |v_{c,f}| * std(f).

However, in librec AoBPR implementation here, p(f|c) is calculated with variance(f) directly. I'm wondering whether it is a bug in AoBPR implementation. Correct me please if I misunderstand something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AaronHeee