From 5179fc315e1336833779160785381907854b1253 Mon Sep 17 00:00:00 2001 From: Arafat2198 <98023601+ArafatKhan2198@users.noreply.github.com> Date: Tue, 28 May 2024 10:26:09 +0530 Subject: [PATCH] HDDS-10867. Clean Up Unnecessary Logs in Recon. (#6703) --- .../ozone/recon/fsck/ContainerHealthTask.java | 14 +++++++------- .../hadoop/ozone/recon/scm/PipelineSyncTask.java | 2 +- .../ozone/recon/tasks/ContainerKeyMapperTask.java | 8 ++++---- .../ozone/recon/tasks/ContainerSizeCountTask.java | 6 +++--- .../ozone/recon/tasks/FileSizeCountTask.java | 6 +++--- .../hadoop/ozone/recon/tasks/NSSummaryTask.java | 2 +- .../ozone/recon/tasks/NSSummaryTaskWithFSO.java | 4 ++-- .../ozone/recon/tasks/NSSummaryTaskWithLegacy.java | 4 ++-- .../ozone/recon/tasks/NSSummaryTaskWithOBS.java | 4 ++-- .../ozone/recon/tasks/OmTableInsightTask.java | 4 ++-- 10 files changed, 27 insertions(+), 27 deletions(-) diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java index 2284fe84e6d..639047d37bd 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java @@ -137,7 +137,7 @@ public void triggerContainerHealthCheck() { long currentTime = System.currentTimeMillis(); long existingCount = processExistingDBRecords(currentTime, unhealthyContainerStateStatsMap); - LOG.info("Container Health task thread took {} milliseconds to" + + LOG.debug("Container Health task thread took {} milliseconds to" + " process {} existing database records.", Time.monotonicNow() - start, existingCount); @@ -163,7 +163,7 @@ private void checkAndProcessContainers( .forEach(c -> processContainer(c, currentTime, unhealthyContainerStateStatsMap)); recordSingleRunCompletion(); - LOG.info("Container Health task thread took {} milliseconds for" + + LOG.debug("Container Health task thread took {} milliseconds for" + " processing {} containers.", Time.monotonicNow() - start, containers.size()); logUnhealthyContainerStats(unhealthyContainerStateStatsMap); @@ -492,11 +492,11 @@ public static List generateUnhealthyRecords( populateContainerStats(container, UnHealthyContainerStates.MISSING, unhealthyContainerStateStatsMap); } else { - if (LOG.isDebugEnabled()) { - LOG.debug("Empty container {} is missing. Kindly check the " + - "consolidated container stats per UNHEALTHY state logged as " + - "starting with **Container State Stats:**"); - } + + LOG.debug("Empty container {} is missing. Kindly check the " + + "consolidated container stats per UNHEALTHY state logged as " + + "starting with **Container State Stats:**"); + records.add( recordForState(container, EMPTY_MISSING, time)); diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/PipelineSyncTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/PipelineSyncTask.java index b802efcf48d..ae3a3531cbf 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/PipelineSyncTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/PipelineSyncTask.java @@ -91,7 +91,7 @@ public void triggerPipelineSyncTask() List pipelinesFromScm = scmClient.getPipelines(); reconPipelineManager.initializePipelines(pipelinesFromScm); syncOperationalStateOnDeadNodes(); - LOG.info("Pipeline sync Thread took {} milliseconds.", + LOG.debug("Pipeline sync Thread took {} milliseconds.", Time.monotonicNow() - start); recordSingleRunCompletion(); } finally { diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java index 0dd5b67f9eb..fd5d8864080 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerKeyMapperTask.java @@ -94,7 +94,7 @@ public Pair reprocess(OMMetadataManager omMetadataManager) { // containerId -> key count Map containerKeyCountMap = new HashMap<>(); try { - LOG.info("Starting a 'reprocess' run of ContainerKeyMapperTask."); + LOG.debug("Starting a 'reprocess' run of ContainerKeyMapperTask."); Instant start = Instant.now(); // initialize new container DB @@ -137,10 +137,10 @@ public Pair reprocess(OMMetadataManager omMetadataManager) { return new ImmutablePair<>(getTaskName(), false); } - LOG.info("Completed 'reprocess' of ContainerKeyMapperTask."); + LOG.debug("Completed 'reprocess' of ContainerKeyMapperTask."); Instant end = Instant.now(); long duration = Duration.between(start, end).toMillis(); - LOG.info("It took me {} seconds to process {} keys.", + LOG.debug("It took me {} seconds to process {} keys.", (double) duration / 1000.0, omKeyCount); } catch (IOException ioEx) { LOG.error("Unable to populate Container Key data in Recon DB. ", @@ -258,7 +258,7 @@ public Pair process(OMUpdateEventBatch events) { LOG.error("Unable to write Container Key Prefix data in Recon DB.", e); return new ImmutablePair<>(getTaskName(), false); } - LOG.info("{} successfully processed {} OM DB update event(s).", + LOG.debug("{} successfully processed {} OM DB update event(s).", getTaskName(), eventCount); return new ImmutablePair<>(getTaskName(), true); } diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerSizeCountTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerSizeCountTask.java index 105406f2bdf..f95bc3a8555 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerSizeCountTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerSizeCountTask.java @@ -98,7 +98,7 @@ protected synchronized void run() { try { int execute = dslContext.truncate(CONTAINER_COUNT_BY_SIZE).execute(); - LOG.info("Deleted {} records from {}", execute, + LOG.debug("Deleted {} records from {}", execute, CONTAINER_COUNT_BY_SIZE); } catch (Exception e) { LOG.error("An error occurred while truncating the table {}: {}", @@ -111,7 +111,7 @@ protected synchronized void run() { endTime = System.nanoTime(); duration = endTime - startTime; durationMilliseconds = duration / 1_000_000; - LOG.info("Elapsed Time in milliseconds for Process() execution: {}", + LOG.debug("Elapsed Time in milliseconds for Process() execution: {}", durationMilliseconds); } } catch (Throwable t) { @@ -197,7 +197,7 @@ public void process(List containers) { // Write to the database writeCountsToDB(false, containerSizeCountMap); containerSizeCountMap.clear(); - LOG.info("Completed a 'process' run of ContainerSizeCountTask."); + LOG.debug("Completed a 'process' run of ContainerSizeCountTask."); } finally { lock.writeLock().unlock(); } diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java index f3c18495e05..cbbbe6c3732 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/FileSizeCountTask.java @@ -81,7 +81,7 @@ public Pair reprocess(OMMetadataManager omMetadataManager) { // Delete all records from FILE_COUNT_BY_SIZE table int execute = dslContext.delete(FILE_COUNT_BY_SIZE).execute(); - LOG.info("Deleted {} records from {}", execute, FILE_COUNT_BY_SIZE); + LOG.debug("Deleted {} records from {}", execute, FILE_COUNT_BY_SIZE); // Call reprocessBucket method for FILE_SYSTEM_OPTIMIZED bucket layout boolean statusFSO = @@ -96,7 +96,7 @@ public Pair reprocess(OMMetadataManager omMetadataManager) { return new ImmutablePair<>(getTaskName(), false); } writeCountsToDB(true, fileSizeCountMap); - LOG.info("Completed a 'reprocess' run of FileSizeCountTask."); + LOG.debug("Completed a 'reprocess' run of FileSizeCountTask."); return new ImmutablePair<>(getTaskName(), true); } @@ -198,7 +198,7 @@ public Pair process(OMUpdateEventBatch events) { } } writeCountsToDB(false, fileSizeCountMap); - LOG.info("Completed a 'process' run of FileSizeCountTask."); + LOG.debug("Completed a 'process' run of FileSizeCountTask."); return new ImmutablePair<>(getTaskName(), true); } diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java index 30fdb7c1292..256e0c687ba 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java @@ -166,7 +166,7 @@ public Pair reprocess(OMMetadataManager omMetadataManager) { TimeUnit.NANOSECONDS.toMillis(endTime - startTime); // Log performance metrics - LOG.info("Task execution time: {} milliseconds", durationInMillis); + LOG.debug("Task execution time: {} milliseconds", durationInMillis); } return new ImmutablePair<>(getTaskName(), true); diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithFSO.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithFSO.java index 9806b198b25..037376bea0b 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithFSO.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithFSO.java @@ -162,7 +162,7 @@ public boolean processWithFSO(OMUpdateEventBatch events) { return false; } - LOG.info("Completed a process run of NSSummaryTaskWithFSO"); + LOG.debug("Completed a process run of NSSummaryTaskWithFSO"); return true; } @@ -210,7 +210,7 @@ public boolean reprocessWithFSO(OMMetadataManager omMetadataManager) { if (!flushAndCommitNSToDB(nsSummaryMap)) { return false; } - LOG.info("Completed a reprocess run of NSSummaryTaskWithFSO"); + LOG.debug("Completed a reprocess run of NSSummaryTaskWithFSO"); return true; } diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java index 4555b976ffe..436d13dcf09 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithLegacy.java @@ -127,7 +127,7 @@ public boolean processWithLegacy(OMUpdateEventBatch events) { return false; } - LOG.info("Completed a process run of NSSummaryTaskWithLegacy"); + LOG.debug("Completed a process run of NSSummaryTaskWithLegacy"); return true; } @@ -294,7 +294,7 @@ public boolean reprocessWithLegacy(OMMetadataManager omMetadataManager) { if (!flushAndCommitNSToDB(nsSummaryMap)) { return false; } - LOG.info("Completed a reprocess run of NSSummaryTaskWithLegacy"); + LOG.debug("Completed a reprocess run of NSSummaryTaskWithLegacy"); return true; } diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithOBS.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithOBS.java index 34c7dc967c3..2601274abbf 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithOBS.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithOBS.java @@ -107,7 +107,7 @@ public boolean reprocessWithOBS(OMMetadataManager omMetadataManager) { if (!flushAndCommitNSToDB(nsSummaryMap)) { return false; } - LOG.info("Completed a reprocess run of NSSummaryTaskWithOBS"); + LOG.debug("Completed a reprocess run of NSSummaryTaskWithOBS"); return true; } @@ -203,7 +203,7 @@ public boolean processWithOBS(OMUpdateEventBatch events) { return false; } - LOG.info("Completed a process run of NSSummaryTaskWithOBS"); + LOG.debug("Completed a process run of NSSummaryTaskWithOBS"); return true; } diff --git a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmTableInsightTask.java b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmTableInsightTask.java index 3e84f311c94..3dc91d0dfc9 100644 --- a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmTableInsightTask.java +++ b/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmTableInsightTask.java @@ -134,7 +134,7 @@ public Pair reprocess(OMMetadataManager omMetadataManager) { writeDataToDB(replicatedSizeMap); } - LOG.info("Completed a 'reprocess' run of OmTableInsightTask."); + LOG.debug("Completed a 'reprocess' run of OmTableInsightTask."); return new ImmutablePair<>(getTaskName(), true); } @@ -208,7 +208,7 @@ public Pair process(OMUpdateEventBatch events) { if (!replicatedSizeMap.isEmpty()) { writeDataToDB(replicatedSizeMap); } - LOG.info("Completed a 'process' run of OmTableInsightTask."); + LOG.debug("Completed a 'process' run of OmTableInsightTask."); return new ImmutablePair<>(getTaskName(), true); }