Llvm14 dev #4
Closed
Llvm14 dev #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: try to get a compilable zig, even with some todos
gwenzek
commented
Jul 4, 2022
| }, | ||
| else => @compileError("Invalid atomic type " ++ @typeName(T)), | ||
| }; | ||
| // LLVM14: broken LLVM module found: Operand for indirect constraint must have elementtype attribute |
There was a problem hiding this comment.
Inline asm changes in LLVM14. Rolledback to an holder version of this code which uses less inline asm
| @@ -9414,7 +9459,7 @@ static void add_fp_entry(CodeGen *g, const char *name, uint32_t bit_count, LLVMT | |||
| { | |||
| ZigType *entry = new_type_table_entry(ZigTypeIdFloat); | |||
| entry->llvm_type = type_ref; | |||
| entry->size_in_bits = 8*LLVMStoreSizeOfType(g->target_data_ref, entry->llvm_type); | |||
There was a problem hiding this comment.
@andrewrk this is how I was planning to solve ziglang#11587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview of my ongoing work on LLVM14 support.
llvm14_master branch is a rebase of ziglang/zig/llvm14 branch onto ziglang/zig/master branch.
llvm14_dev branch is where I put my original work.
This allow to keep the diff to a reasonable size.