Fixed upstream #505 : spurious warning on adm5 terminal #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwsw
added a commit
that referenced
this pull request
Sep 9, 2024
Fix for issue #505 ("Wrong warning when running on Lear Siegler ADM-5 terminal") The cheaper function that compares two ways of using termcap sets missing_cap to 1 if both ways are unavailable. This function is used to choose between using "al" or "sr" ("add line" or "scroll reverse") to add a line at the top of the screen. None of those are available on an ADM5 terminal. However, less already has support for terminal that lacks reverse scroll, and is correctly setting the no_back_scroll, making the warning wrong. Source code already had a provision to avoid using cheaper if none of the capabilities were available, but it was only used for OS2. I enabled this for all builds. I don't see any potential for any regression. Related to #505. Manually merged from #506.
|
Manually merged in deb4981. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #505 ("Wrong warning when running on Lear Siegler ADM-5 terminal")
The
cheaperfunction that compares two ways of using termcap setsmissing_capto 1 if both ways are unavailable. This function is used to choose between using "al" or "sr" ("add line" or "scroll reverse") to add a line at the top of the screen. None of those are available on an ADM5 terminal.However,
lessalready has support for terminal that lacks reverse scroll, and is correctly setting theno_back_scroll, making the warning wrong.Source code already had a provision to avoid using
cheaperif none of the capabilities were available, but it was only used for OS2. I enabled this for all builds. I don't see any potential for any regression.