Support ElementType MODULE and RECORD_COMPONENT on annotations #10002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While GWT has no use for JPMS modules, sources that rely on this target fail to compile with GWT (causing an error in JDT that results in a hard-to-interpret asm stack trace). Fixes gwtproject#10001
tbroyer
reviewed
Sep 11, 2024
| @@ -22,5 +22,5 @@ | |||
| */ | |||
| public enum ElementType { | |||
| ANNOTATION_TYPE, CONSTRUCTOR, FIELD, LOCAL_VARIABLE, METHOD, PACKAGE, | |||
| PARAMETER, TYPE, TYPE_PARAMETER, TYPE_USE, | |||
| PARAMETER, TYPE, TYPE_PARAMETER, TYPE_USE, MODULE, | |||
There was a problem hiding this comment.
We don't seem to care about the exact ordinal so maybe keep them alphabetically sorted?
There was a problem hiding this comment.
Ah, I had intended to keep them in the original order (MODULE was the new last element as of Java 11).
I'll re-order just in case something silly happens with ordinal values... though as my trip into bytecode shows, the name of the enum constant is what matters for annotation values.
There was a problem hiding this comment.
On second thought, I do see that the entire list is alphabetical, my spot check of "hmm, TYPE_USE is last, so it must be append-only" was faulty. I'll stick with that ordering for now, and add RECORD_COMPONENT.
niloc132
changed the title
tbroyer
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While GWT has no use for JPMS modules, sources that rely on this target fail to compile with GWT (causing an error in JDT that results in a hard-to-interpret asm stack trace).
Fixes #10001