Add a feature for decoding base64-encoded string #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decode base64 to false
- Rename `EncodeBase64` to `EncodeBase64StrToStr` - Rename `DecodeBase64` to `DecodeBase64StrToStr` - Add new function `DecodeBase64StrToBytes` - Update usages of the renamed functions in `util.go`
The code changes in this commit update the `Save` method in the `SecretHandler` struct to handle base64 encoded secrets. If the `decodeBase64EncodedSecret` flag is set to true, the secret is decoded from base64 and then saved to the specified file. This allows for more flexibility in handling secrets that are stored in base64 format.
The code changes in this commit add a new function `DecodeBase64BytesToBytes` to the `util.go` file. This function decodes a base64 encoded byte slice and returns the decoded bytes. Additionally, the existing `DecodeBase64StrToBytes` function is modified to use the `base64.StdEncoding.Decode` method instead of `base64.RawStdEncoding.DecodeString`. This ensures consistent decoding behavior across the codebase.
The Save method in the SecretHandler struct is updated to handle base64 encoded secrets. If the decodeBase64EncodedSecret flag is set to true, the secret is decoded from base64 and then saved to the specified file. This allows for more flexibility in handling secrets that are stored in base64 format.
The IsInected method in the Annotations struct is renamed to IsInjected to accurately reflect its purpose of checking if a specific annotation is present. This improves code readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #33