Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset response body #40

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Conversation

iliacimpoes
Copy link
Contributor

@iliacimpoes iliacimpoes commented Oct 29, 2018

Mocked response body does not match the real http.Response.Body behavior.
Response body should not be reset when it is read till EOF.

If you accidentally read response body twice tests using mocked response won't fail, but they should.

@h2non h2non merged commit 65dac6c into h2non:master Oct 29, 2018
@h2non
Copy link
Owner

h2non commented Oct 29, 2018

LGTM. Thanks!

@iliacimpoes
Copy link
Contributor Author

@h2non thanks for the quick review

@iliacimpoes iliacimpoes deleted the DoNotResetResponseBody branch October 30, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants