[WIP] Don't use gc in pandas join benchmark. #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gc is not guaranteed to clear up memory usage, each package can hold additional references in Python or in C/C++ as they see fit. * Remove duplicated code in running benchmarks.
|
Pandas join benchmark is out of date. Initially, in 2016, this benchmark was testing mostly distributed tools + pandas, data.table, dplyr. If you are interested in those you may want to check this talk https://www.youtube.com/watch?v=5X7h1rZGVs0 |
|
@jangorecki Thanks for the explanation. |
Tmonster
added a commit
to Tmonster/db-benchmark
that referenced
this pull request
Jul 2, 2024
…h within the time limit for the smaller scale factors, but on the larger ones, I don't like waiting 6 hours only for a timeout to be reached (h2oai#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional references in Python or in C/C++ as they see fit.