Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightwave #1818

Merged
merged 35 commits into from
Feb 24, 2023
Merged

Lightwave #1818

merged 35 commits into from
Feb 24, 2023

Conversation

mturoci
Copy link
Collaborator

@mturoci mturoci commented Jan 31, 2023

Closes #1796

@mturoci mturoci requested a review from lo5 as a code owner January 31, 2023 16:03
lo5
lo5 requested changes Feb 15, 2023
View reviewed changes
Copy link
Member

@lo5 lo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer "Wave Lite" instead of "Wavelite" if that's the name we're going for.
We can also brainstorm other names (lightwave?).

py/h2o_wavelite/README.md Outdated Show resolved Hide resolved
py/h2o_wavelite/README.md Outdated Show resolved Hide resolved
py/h2o_wavelite/README.md Outdated Show resolved Hide resolved
py/h2o_wavelite/README.md Outdated Show resolved Hide resolved
@lo5
Copy link
Member

lo5 commented Feb 15, 2023

Overall, great PR. I like how minimal the changes are.

What about the file upload/download routines from Wave - those won't function properly in the light version, correct?

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 16, 2023

What about the file upload/download routines from Wave - those won't function properly in the light version, correct?

They are not part of the python API at all meaning the type system should take care of it. Will make this clear in the README though.

@mturoci
Copy link
Collaborator Author

mturoci commented Feb 16, 2023

We can also brainstorm other names (lightwave?)

Definitely, created a poll in Slack to get broader ideas. Wavelite was just the first thing that came to my mind, not final for sure.

@mturoci
feat: Initial impl. #1796
fc6bb15
@mturoci
feat: Initial packaging. #1796
8aeabdd
@mturoci
fix: Make the wavelite work for args, events and UI rendering. #1796
bc6a848
@mturoci
chore: Strip down unused stuff. #1796
c5ae852
@mturoci
chore: Strip down unused stuff. #1796
b698d37
@mturoci
chore: Separate into proper python package. #1796
9ddfac8
@mturoci
chore: Update python setup target #1796
a44a72e
@mturoci
chore: Restructure python packages. #1796
6be7072
@mturoci
chore: Split wavelite and its web assets into separate python packages.
3199752 
#1796
@mturoci
feat: Update types for wavelite as well when generating python UI cla…
5831602 
…sses. #1796
@mturoci
docs: Add proper readme. #1796
1eb69e0
@mturoci
chore: Get rid of user state. #1796
ce91efb
@mturoci
ci: Add job for wavelite. #1796
2ffe51d
@mturoci
feat: Keep client state only. #1796
045a0a5
@mturoci
chore: Refactor. #1796
929b11a
@mturoci
chore: Revert wizard changes. #1796
86b28d5
@mturoci
feat: Allow injecting wavelite into existing pages. Allow ws config. #…
f550afa 
…1796
@mturoci
feat: Scope id of the root HTML container. #1796
db75742
@mturoci
docs: Add FastAPI example. #1796
5837c4c
@mturoci
chore: Mark wavelite as beta. #1796
ec13ec8
@mturoci
fix: Remove leading slash from prefix if specified. #1796
67c212a
@mturoci
docs: Add running instructions. #1796
3e970ba
@mturoci
docs: Add integration example. #1796
aa531ba
mturoci and others added 7 commits February 24, 2023 11:40
@mturoci @lo5
Update py/h2o_wavelite/README.md
461c549 
Co-authored-by: Prithvi <prithvi.prabhu@gmail.com>
@mturoci @lo5
Update py/h2o_wavelite/README.md
3c9df27 
Co-authored-by: Prithvi <prithvi.prabhu@gmail.com>
@mturoci @lo5
Update py/h2o_wavelite/README.md
44725fa 
Co-authored-by: Prithvi <prithvi.prabhu@gmail.com>
@mturoci @lo5
Update py/h2o_wavelite/README.md
ee6bc6f 
Co-authored-by: Prithvi <prithvi.prabhu@gmail.com>
@mturoci
docs: Use HTML response in custom index.html examples to make them si…
df1f799 
…mpler. #1796
@mturoci
chore: Rename to lightwave #1796
ba63e3a
@mturoci
ci: Try building lightwave_web package during setup. #1796
aaaa990
@mturoci mturoci changed the title Wavelite Ligthwave Feb 24, 2023
@mturoci mturoci changed the title Ligthwave Ligthtwave Feb 24, 2023
@mturoci mturoci changed the title Ligthtwave Lightwave Feb 24, 2023
@mturoci mturoci merged commit 19c8b1d into master Feb 24, 2023
@mturoci mturoci deleted the feat/issue-1796 branch February 24, 2023 11:26
mturoci added a commit that referenced this pull request Mar 7, 2023
@mturoci
feat: Lightwave #1796 (#1818)
a7554e4
@emmanuel-ferdman emmanuel-ferdman mentioned this pull request Jun 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo5 lo5 lo5 requested changes

@geomodular geomodular Awaiting requested review from geomodular

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wavelite - make Wave integratable within arbitrary python web frameworks (Django, Flask, FastAPI etc.)
2 participants
@mturoci @lo5