Infer streaming URL from instance information #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASTRELION
commented
Mar 2, 2024
|
It is a little breaking change, so I will merge it in the next minor release (not a patch release). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to infer the base streaming URL from the instance information instead of needing to manually provide it separately. It does this by calling
get_instance()and retrieving thestreaming_apiURL if available, otherwise it will use thebase_urlof the client.This is obviously a breaking change, since the function signatures for all the streaming functions have all become
asyncand thestreaming_urlparameter is removed.