Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add ESM support #1701

Closed
mashirozx opened this issue May 4, 2023 · 3 comments
Closed

Feature request: add ESM support #1701

mashirozx opened this issue May 4, 2023 · 3 comments

Comments

@mashirozx
Copy link

mashirozx commented May 4, 2023 •
edited
Loading

Currently we are using cjs modules, but it's not friendly to some modern tool chains, see.

This lib is currently compiled with tsc, but it can't compile into ESM perfectly, see. It may needs to introduce bundler like Rollup and SWC.
@ThatOneCalculator
Copy link
Contributor

ThatOneCalculator commented Sep 22, 2023 •
edited
Loading

Related: #1923

Setting it to ESModules (see b73a654) doesn't work properly, a lot of files end up as export {};

ThatOneCalculator added a commit to ThatOneCalculator/megalodon that referenced this issue Sep 22, 2023
@ThatOneCalculator
target esmodules
b73a654 
BREAKING: NodeJS 16 minimum

Closes h3poteto#1701
@ThatOneCalculator
Copy link
Contributor

Will be closed by #1963

@Ryuno-Ki
Copy link
Contributor

Looks like that auto-close didn't happen 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ryuno-Ki @h3poteto @mashirozx @ThatOneCalculator